microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.55k stars 8.31k forks source link

Add an option to revert to old alpha-based selection colors #17837

Open MatejKafka opened 2 months ago

MatejKafka commented 2 months ago

In v1.22, selection colors were changed significantly to make the selection have uniform foreground and background color. However, the new colors are imo hard to read due to excessive contrast and they interact poorly with text with varying background and foreground color (see image 4 and 5). Also, using glyphs to create rounded corners on blocks with different background colors breaks with the new selection behavior (see image 3).

Personally, I much prefer the previous alpha-based selection. Could you add an option to revert to the previous behavior?

v1.21, the pretty alpha-based selection: image

v1.22, too much contrast, imo does not look as good: image


Bad rendering for rounded corners using glyphs: image


v1.22 hides all background colors: image

v1.21 preserves background colors, which imo looks better: image

zadjii-msft commented 2 months ago

Other discussions that might be relevant: