microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!

MIT License

95.43k stars 8.3k forks source link

Bug Report: Settings Do Not Open #2036

Closed lnorton89 closed 5 years ago

lnorton89 commented 5 years ago

Environment

Windows build number: 10.0.18362.239
Windows Terminal version: Latest

Steps to reproduce

Open Windows Terminal and try to open the settings via the arrow button.

Expected behavior

A settings dialog opens.

Actual behavior

Nothing.

alefnull commented 5 years ago

currently the settings are stored in and edited via a JSON file, so you'll need to associate a text editor with JSON files in your system settings. after that, clicking the settings button will open the settings JSON file for you to edit as you wish.

kyleskrinak commented 5 years ago

I have confirmed that my system has mapped *.json to vim, yet control-comma or choosing “Settings” from the tabbed menu fails to load the settings file. Or, as the OP says; “nothing” happens.

DHowett-MSFT commented 5 years ago

Alas, this is a silly bug. #1789 It's been fixed, and that fix is just waiting for another release.

DHowett-MSFT commented 5 years ago

The core of the issue is that gvim registers itself for the "edit" verb but we were using the "open" verb. The fix for 1789 also added a fallback to Notepad just in case nothing was able to open it.