microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.25k stars 8.27k forks source link

Don't resize the terminal buffer until dragging is released #2140

Open zadjii-msft opened 5 years ago

zadjii-msft commented 5 years ago

Add a setting to enable this behavior.

Maybe the user might not want to reflow the buffer in real-time as they resize the window. Maybe they only want to have the resize occur when they finish resizing.

I'd love to see an E2E spec of this scenario before code starts getting written, because I feel it might be a little wonky in certain scenarios. Questions that would be good to be answered:

From discussion in #1465

miniksa commented 5 years ago

I thought this was already handled for us by the operating system in this option: image

If that's off, the OS shouldn't be telling us the move/size messages until it is released. If it's on, the OS tells us.

Are we saying that's not enough or that we need to override that further?

zadjii-msft commented 5 years ago

Yea I think this is for a more refined feature on top of that. Since conpty does re-rendering on resizes, people might want to only have the terminal actually process the new buffer size at the end of the resize.