microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.1k stars 8.25k forks source link

Touch Zoom with two fingers don't work on Touch screen (but it works on Touch Pad) #3149

Open DrPepperBianco opened 4 years ago

DrPepperBianco commented 4 years ago

Description of the new feature/enhancement

When I use two finger to zoom in or out (actually making text bigger or smaller), it works on my touch pad. But it actually don't work on my touch screen.

I think the experience would be much smoother if it worked the same on the touch pad and the touch screen.

What I also get is, if I scroll with finger on the touch screen it works. If I try to scroll with two fingers it flickers, as if the program doesn't realize I using two fingers and tries to read both inputs.

So the case with multiple fingers should probably be detected and handled specifically.

Proposed technical implementation details (optional)

If I use two fingers on the touch screen and move them together or away from each other the font size should decrease or increase respectively, exactly as it is now if I do that on the touch screen.

carlos-zamora commented 4 years ago

This should be a fairly easy thing to implement. Adding the Help-Wanted tag if anybody wants to hop on. The work should be done in the TermControl.cpp file. There's a few pointer-related functions (i.e.: pointerMoved, pointerClick, etc.) that already handle the mouse movements and a few touch events. Now just a matter of expanding on the touch events.

carlos-zamora commented 4 years ago

https://docs.microsoft.com/en-us/windows/uwp/design/input/touch-interactions

Just linking this here for when I (or somebody else) comes by 😊