microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!

MIT License

95.64k stars 8.32k forks source link

Update Preview icon to align with Edge #6024

Open Studio384 opened 4 years ago

Studio384 commented 4 years ago

Environment

Windows build number: 19628
Windows Terminal version (if applicable): 1.0.1402

Steps to reproduce

Install Windows Terminal Preview

Expected behavior

The Terminal Preview icon and Edge Insider icon's preview-labels line up nicely and use the same font and size.

Actual behavior

Given the basic design, it feels obvious that the Terminal Preview's "Preview" label is modelled after the Microsoft Edge icon.

But the labels don't line up nicely and a different font (weight) is used for the Terminal compared to Edge.

It's a very insignificant issue. But I'd just like to point it out because - as someone who uses both regularly - it annoys me. 🙃

DHowett commented 4 years ago

@cinnamon-msft we'll need to move the pill around a little bit. I'll see if I can do that for fun in my icon generation script.

Had some ideas about merging the pill in as a separate image instead of part of the terminal icon which will give us breathing room on the larger tiles where there's more than space enough for the icon

k-yle commented 4 years ago

It's also worth noting that on lower-resolution displays the Edge Dev icon still shows the badge with text, but the terminal icon removes the text and just shows a blue bar.

DHowett commented 4 years ago

@k-yle given that our badge is shorter than Edge's, we thought it imprudent to have a tiny black smear you didn't stand a chance of reading.

Sidneys1 commented 4 years ago

@k-yle given that our badge is shorter than Edge's, we thought it imprudent to have a tiny black smear you didn't stand a chance of reading.

FYI, the badge does display with text when pinned to the start menu as a "small" size icon: