search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95k stars 8.22k forks source link

Redrawing / flickering issues while using Magnifier #6692

Open DonQuinleone opened 4 years ago

DonQuinleone commented 4 years ago

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]

Microsoft Windows [Version 10.0.18363.900]     

Windows Terminal version (if applicable):

1.0.1401.0

Any other software?

zsh 5.7.1 (x86_64-debian-linux-gnu)
Running on WSL1

Steps to reproduce

Open Magnifer on Windows, and use Ctrl+Alt+Scroll Wheel shortcut to zoom in and out

Either just use ZSH, or open any terminal application (in this case htop, nano, vim and micro)

Expected behavior

None of the contents of the terminal should change.

Actual behavior

Everything displayed within Terminal is redrawn, which makes it virtually unusable for me.

Additionally, this seems to force ZSH to re-run, but this does not happen in bash.

Lastly, the OS-selector / app info dropdown enlarges as you zoom in.

Here's a video showcasing the issues with ZSH/htop/vim/micro: https://youtu.be/qUZRsuhJV5M

And here's a video showing how bash is not affected, and the resizing dropdown menu: https://youtu.be/MRsJl6bgIVQ

I really love Windows Terminal, so I really hope you can get this fixed, as it would make a huge difference to me. For reference, I am registered blind, so rely completely on Magnifier for my work.

DHowett commented 4 years ago

Oh! Oh no!

I think this is because terminal is receiving Ctrl+Mouse Wheel at the same time. It's doing its own font zooming in response to that, and that change in text size causes the remote application (zsh, micro) to redraw the entire screen.

DHowett commented 4 years ago

Either we need a way to disable the zooming shortcuts, detect that Magnifier is running, or don't do the Terminal character zoom when Alt is held down.

DonQuinleone commented 4 years ago

Thanks so much for the quick response @DHowett! Really appreciate it.

Would love a patch for this, but I totally appreciate there are more important issues. Whenever you get a chance :-)

Other than this, awesome job on the emulator - it's fantastic!

DHowett commented 4 years ago

Thanks :smile:

leonMSFT commented 3 years ago

So I've attempted to repro this on a couple of our more recent builds (1.9 and up), but could not get it to repro with the same steps. 😥 It's very possible it's been fixed by some other bugfix, perhaps to how we deal with modifiers. Could you see if you can still repro the bug?

muhammedogz commented 3 years ago

I also had some the problem so I was watching this topic.

I can confirm that this terminal behavior is solved. It was occurring when so many lines on terminal. So I tested with infinite print loop and nothing happened.

So I guess it is fixed.

Edit: I forgot to mention it. I am also using windows magnifier 7/24 with windows terminal.

zadjii-msft commented 3 years ago

Cool, glad to hear it!

muhammedogz commented 3 years ago

I sad it fixed but it still happens.

I tried some cases to see it will triggered or not.

When I install an npm package, for example npm install -g matrix-rain

If my text cursor focused to terminal and I use my mouse to look another place. It does not allows to look and keep focusing and it causes closing the terminal.

@zadjii-msft