microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.24k stars 8.27k forks source link

Cannot preinstall WT package 1.4.3141.0 Windows10_PreinstallKit.zip on Windows Server 10.0.20251.1000 #8243

Closed PGomersall closed 3 years ago

PGomersall commented 3 years ago

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] Windows Server 10.0.20251.1000
Windows Terminal version (if applicable): N\A

Any other software?

Steps to reproduce

1) Open elevated Powersell Downloaded provided package zip, unblocked and expanded to C:\WT Run Add-AppxProvisionedPackage -Online -FolderPath C:\WT Add-AppxProvisionedPackage : No applicable main package was found for this platform. The directory must contain an applicable package with a .main file extension. For more information, see the help. Same result when specifying the msixbunde file with -PackagePath and the license file with -License. Using -FolderPath also doesn't work on W10 20H2, but specifying the files specifically does

Expected behavior

Actual behavior

Installs WT for all users should work on Windows Server vNext?

zadjii-msft commented 3 years ago

Wait what? where are you getting this PreinstallKit.zip file? That doesn't look like something that we ship. IIRC we're only shipping an msixbundle for the packaged release

WSLUser commented 3 years ago

https://github.com/microsoft/terminal/releases/download/v1.4.3141.0/Microsoft.WindowsTerminal_1.4.3141.0_8wekyb3d8bbwe.msixbundle_Windows10_PreinstallKit.zip

WSLUser commented 3 years ago

@DHowett started issuing them the last release or two ago.

PGomersall commented 3 years ago

Yes as @WSLUser notes: https://github.com/microsoft/terminal/releases/download/v1.4.3141.0/Microsoft.WindowsTerminal_1.4.3141.0_8wekyb3d8bbwe.msixbundle_Windows10_PreinstallKit.zip

zadjii-msft commented 3 years ago

Alright well, I'll defer to Dustin then because I have no idea what that is 😄

DHowett commented 3 years ago

So you did this successfully on Windows Client? Interesting! Can you grab a copy of C:\Windows\Logs\DISM.log after a failed apply?

We’ve only validated that the PreinstallKit works on Client, so I’m not surprised that there might be an issue here.

PGomersall commented 3 years ago

@DHowett Yes works on most recent W10 client: 10.0.19042.630 Here you go with the log file: dism.log Tried a few different options on\after: 2020-11-12 07:50:34

Note that using the -FolderPath with Add-AppxProvisionedPackage approach also failed on the client. The client only worked specifying the msixbundle file and license file explicitly.

Just installing the msixbundle for each user works though on Server.

DHowett commented 3 years ago

This is really strange! Every failure says:

    Msg:[Failed while adding license file '.\6520b63bb369427b9cfbf867f6ab2cb4.msixbundle'] 

It's as though it's attempting to parse the bundle itself as a license. That seems deeply incorrect.

I'll reach out to the DISM team and see if I can reproduce this on Server myself. :smile:

PGomersall commented 3 years ago

In the GA release of Server 2022 it seems to be fixed. Install WT using -PackagePath and _LicenseFile works