microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.03k stars 8.23k forks source link

Add a setting to configure display of auto detected links, normally and on hover #8294

Open PankajBhojwani opened 3 years ago

PankajBhojwani commented 3 years ago

Description of the new feature/enhancement

Allow the user to define how detected patterns should be displayed, when hovered and not.

See (see https://github.com/microsoft/terminal/pull/7691#issuecomment-727620804) and this

Wanted to make this an official issue where we can discuss the extent to which this should be implemented (should it just be limited to font style? or also font face? and what about font size? or other effects too)

zadjii-msft commented 3 years ago

So, mixing and matching multiple fonts in the same TermControl might be Hard, so let's leave different font faces out of the question for now. I think different attributes seems reasonable, but how do we express that in the JSON?

PankajBhojwani commented 3 years ago

I think different attributes seems reasonable, but how do we express that in the JSON?

How does a map of key-value pairs sound? Allowed keys are foreground, background and any of the ExtendedAttributes values

zadjii-msft commented 3 years ago

wait so then it's

"foreground": "red", // a 16-color table value
"background": "#0044ff", // an RGB value
"underlined": true // ?
DHowett commented 3 years ago

We need to comport this with the configuration flags for specifying different fonts, suggested in ... some workitem that exists on this repo. I don't want to do this without doing that, and they should definitely look roughly the same in terms of user-facing options.

DHowett commented 3 years ago

That would be #1790.