search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.64k stars 8.32k forks source link

Scroll wheel does not work in settings UI #9340

Closed ghost closed 3 years ago

ghost commented 3 years ago

Environment

Windows build number: 10.0.19042.0
Windows Terminal version (if applicable): 1.7.572.0

Steps to reproduce

Open Windows Terminal tab & settings UI tab

Expected behavior

Scrolling with mouse wheel should work on both tabs

Actual behavior

scroll_test

zadjii-msft commented 3 years ago

oh my gosh is this that weird trackpad bug? Lemme try finding that in the history.

@otaconjh What mouse are you using to scroll the Terminal? Is it by any chance a synaptics trackpad?

EDIT: My theory is that this is a variation on #979, #2606 and microsoft/microsoft-ui-xaml#2101

ghost commented 3 years ago

It occurred on my work laptop but I was using a bluetooth mouse. 'HID-compliant mouse' in Device Manager

zadjii-msft commented 3 years ago

Okay, well, that kinda ruins my theory about the trackpad. Other guesses:

ghost commented 3 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

ghost commented 3 years ago

Issues with scrolling are with mouse only, scrolling works fine when a trackpad is used. Have tested with multiple mice.

zadjii-msft commented 3 years ago

Issues with scrolling are with mouse only, scrolling works fine when a trackpad is used. Have tested with multiple mice.

what the heck? That's even weirder than I had expected. I'm gonna leave this open for now. My guess is that the hack we're doing to manually pass mouse events into the TermControl is what's making the mouse work for you in terminal tabs, but not the settings tab (or command palette). However, I'm not sure we can do that same hack for those UI elements. I don't know how to narrow the issue down more at this point, unfortunately. I'd bet that this is a Xaml Islands bug, but unsure where the root cause is exactly.

https://github.com/microsoft/PowerToys/issues/3400 also looks like another case of this, an one where they're similarly seeing this with a mouse, not a trackpad. @otaconjh Out of curiosity, which mice did you try?

jackemerson commented 3 years ago

microsoft/PowerToys#3400 also looks like another case of this, an one where they're similarly seeing this with a mouse, not a trackpad. @otaconjh Out of curiosity, which mice did you try?

Just to add some additional information, this issue occurs for me across PowerToys' and Windows Terminal's settings panels. It occurs only on my desktop, and not my laptop.

Desktop

The issue occurs with any of the following mice:

...I may need to take a look at my mice hoarding habit.

System Info Microsoft Windows Pro 64-bit [Version 10.0.19042.928] Windows Terminal Version: 1.7.1033.0 Microsoft PowerToys Version: 0.35.0 CPU: Intel i7-7700K GPU: NVIDIA GTX 1070 User DPI Setting: 120 DPI (125 percent) System DPI Setting: 96 DPI (100 percent) Monitor, Primary: 27", 2560 x 1440 (32 bit) (144Hz) Acer XB271HU Monitor, Second: 34", 3440 x 1440 (32 bit) (60Hz) Dell U3419W

Laptop

For my laptop (Dell XPS 9360), there are no issues with scrolling the settings panel, with either the trackpad or with a mouse (tested with MX Master 2s & G703).

System Info Microsoft Windows Home 64-bit [Version 10.0.19042.867] Windows Terminal Version: 1.7.1033.0 Microsoft PowerToys Version: 0.35.0 CPU: Intel i7-7500U GPU: NVIDIA GTX 1070 User DPI Setting: 144 DPI (150 percent) System DPI Setting: 144 DPI (150 percent) Monitor: 13", 1920 x 1080 (32 bit) (60hz)

Changing the DPI and/or resolution for my desktop and laptop did not (respectively) allow me to, or stop me from, scrolling the settings panel.

I'll test this further with a restart following the DPI and/or resolution change, and report back.

loopervfx commented 3 years ago

I am also unable to scroll in Terminal v1.8.1444.0 Settings, I'm using a Kensington Expert Mouse Wired Trackball (USB) on Windows 10 ver 1909 build 18363.1379

jaortizco commented 3 years ago

I have the same problem, I can scroll everywhere with my touchpad (Synaptics) except in the settings tab. It works fine when I use my Bluetooth mouse.

Windows Terminal Version: 1.8.1521.0

timadye commented 3 years ago

I had this same issue, but only in a specific set of circumstances, and now have a work-around. Here's what I observed:

That last point indicates that it's something going on with XMBC. If it were a problem, I could take it up with them. But actually it's easier just to "Disable Scroll Window Under Cursor". XMBC That option doesn't seem to do anything - I guess Windows now has this behaviour built-in, so there's no need to have XMBC do it. I didn't see a problem like this before I saw it in Windows Terminal Settings, so there is some funny interaction between the two programs.

I hope that gives a clue as to what's going on for other people who aren't so lucky to have an easy fix as (it looks like) I have. It might be possible for a developer to reproduce the issue by installing XMBC (making sure that option is not selected) and using an external mouse.

So this isn't a problem for me, but I hope my observation helps. Tim.

Windows Terminal v1.9.1942.0. X-Mouse Button Control v2.19.2. Windows 10 20H2.

jackemerson commented 3 years ago

Well, you're absolutely right. I've run XMBC for so long, I didn't even consider it. 😑

So disabling the relevant Global Setting: image or (as you mentioned, also) disabling it on a matched profile sorts this issue out.

Cheers, Tim!

loopervfx commented 3 years ago

I also use X-Mouse Button Control and @timadye's workaround resolved the issue for me. @jackemerson's option also worked and is a less error prone solution in the long run. Same results for PowerToys settings scroll issue https://github.com/microsoft/PowerToys/issues/3400

zadjii-msft commented 3 years ago

Wow that's crazy. Glad someone was able to get to the bottom of this!

loopervfx commented 3 years ago

Wow that's crazy. Glad someone was able to get to the bottom of this!

for posterity sake, this issue hasn't been isolated / confirmed to be caused by X-Mouse Button Control or due to a conflict with this software exclusively. Only that a workaround has been found in this case. According to reports here and in the still open Power toys sister issue, This maybe also be happening with Synaptics and/or Logitech input devices, due to a conflict or flaw with their configuration software, drivers, and/or Windows.

rozele commented 3 years ago

This issue also repro's when using WizMouse.

rozele commented 3 years ago

In case anyone is interested, I implemented a workaround for this for a react-native-windows app built on XAML Islands: https://gist.github.com/rozele/a4b26810b9a4f68373e421a49d06a5ab

rozele commented 2 years ago

Also, just noticed that the bug "goes away" if you open Spy++ and put it in focus while trying to scroll the Settings tab 😮

Haas11 commented 2 years ago

In case anyone is interested, I implemented a workaround for this for a react-native-windows app built on XAML Islands: https://gist.github.com/rozele/a4b26810b9a4f68373e421a49d06a5ab

also when using alt-drag