microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!

MIT License

94.36k stars 8.17k forks source link

Windows Terminal fails to instantiate Azure Shell when it is configured with an isolated VNET #9344

Open robey-ms opened 3 years ago

robey-ms commented 3 years ago

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.1379]
Windows Terminal version (if applicable):  Version: 1.0.1401.0

Any other software? No

Steps to reproduce

Configure Cloud Shell with isolated VNET settings per https://docs.microsoft.com/en-us/azure/cloud-shell/private-vnet Validate correct Cloud Shell behavior with https://shell.azure.com In Windows Terminal attempt to create a new session for Azure Cloud Shell

Expected behavior

Cloud shell opens.

Actual behavior

Cloud shell fails to instantiate with the messages: You have not set up your cloud shell account yet. Please go to https://shell.azure.com to set it up. [process exited with code 1]

zadjii-msft commented 3 years ago

Thanks for the report!

DHowett commented 3 years ago

Thanks indeed. This is another one of the unfortunate side effects of having reverse-engineered their protocol. :smile:

DHowett commented 3 years ago

Also:

Windows Terminal version (if applicable): Version: 1.0.1401.0

wow. It's been a while! We're at 1.6 now :smile:

Don-Vito commented 3 years ago

Thanks indeed. This is another one of the unfortunate side effects of having reverse-engineered their protocol. 😄

Not sure if the feature existed when the protocol was reversed. IMHO it wasn't there from beginning.

robey-ms commented 3 years ago

Feature went live in Sept I think. And yes I need to get them to approve a newer version for our images. Once this is fixed I'll jump on it. :)

ThomasPiskol commented 3 years ago

Any news regarding this issue? Currently it's added to the 2.0 milestone and that's the end of this year 🥺 Is there any change that it will get fixed in an earlier version?

zadjii-msft commented 3 years ago

Nope. We'll make sure to update this thread when there is.

We usually pivot from focusing mostly on features to mostly on bugs later in the cycle, so it'll probably be a few months before anyone on the team gets to this. If a community member is particularly driven though, we'd be happy to review a PR ☺️

Gheedit commented 6 months ago

Hello there, I saw this issue has been moved to backlog. Originally I faced this issue over 1 year ago and have since been frequently checking this thread. So far there have been little to no updates. Although that was the case, I tested it recently anyway.

I set up a VNet integrated cloud shell in my own Azure subscription and used the templates provided by Microsoft. (Cloud Shell VNet and Cloud Shell VNet Storage)

After set up was complete, I tried to connect to the cloud shell over windows terminal. Result: vnetintegrated_cloudshell_on_windowsterminal

Note the line "Requesting a terminal (this might take a while)...". Though it's for sure a bit of a non-technical reason, this line only appears, when a terminal is requested from a vnet integrated cloud shell. I unfortunately do not have my set up anymore, so I can't provide more detail at the moment.

So here is my question: Has this issue been fixed in the meantime without anyone updating this thread?

Best, Gheedit

lhecker commented 6 months ago

If it's fixed, we didn't fix this intentionally. Maybe something has changed on Azure's side of things? I'll keep this issue open just in case this was an one-off thing.