New resource `azuredevops_feed` `azuredevops_feed_permission` Data source `azuredevops_feed` Basic Feed Management

SetsudanHana commented 6 months ago

All Submissions:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My code follows the code style of this project.
[x] I ran lint checks locally prior to submission.
[x] Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number:

Does this introduce a change to `go.mod`, `go.sum` or `vendor/`?

[x] Yes
[ ] No

Does this introduce a breaking change?

[ ] Yes
[x] No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

SetsudanHana commented 6 months ago

@microsoft-github-policy-service agree

SetsudanHana commented 6 months ago

Fixes #905 Fixes #50

SetsudanHana commented 6 months ago

@xuzhang3 Kindly asking for review, thanks

favoretti commented 6 months ago

@xuzhang3 ping here too please, much awaited functionality :)

SetsudanHana commented 5 months ago

Hello, @xuzhang3, I will be adding another resource to this PR, because we found during testing the necessity of having the ability to grant permissions to the feed so I will introduce azuredevops_feed_permission for that purpose If it is fine with You

SetsudanHana commented 5 months ago

Hello, @xuzhang3, I will be adding another resource to this PR, because we found during testing the necessity of having the ability to grant permissions to the feed so I will introduce azuredevops_feed_permission for that purpose If it is fine with You

It looks like it can not be a separate resource, given the current client only supports SetFeedPermissions and GetFeedPermissions so I will incorporate it within the azuredevops_feed resource

xuzhang3 commented 5 months ago

@SetsudanHan you can create a new PR based on this PR or waiting this PR merged

SetsudanHana commented 5 months ago

@SetsudanHan you can create a new PR based on this PR or waiting this PR merged

Well, ideally we need both at the same time, I think I figured out how the API works to implement it correctly, so I would prefer putting it in the same PR if it is fine with You

xuzhang3 commented 5 months ago

@SetsudanHan you can create a new PR based on this PR or waiting this PR merged

Well, ideally we need both at the same time, I think I figured out how the API works to implement it correctly, so I would prefer putting it in the same PR if it is fine with You

It’s okay to put them together, but it’s recommended to separate into different PR.

SetsudanHana commented 5 months ago

Hello @xuzhang3, so I have added the Feed Permission management, please review it when you have some time (AC, Units, and documentation added)

xuzhang3 commented 4 months ago

=== RUN   TestAccAzureDevOps_Resource_FeedPermission
=== PAUSE TestAccAzureDevOps_Resource_FeedPermission
=== RUN   TestAccAzureDevOps_Resource_Feed
=== PAUSE TestAccAzureDevOps_Resource_Feed
=== RUN   TestAccAzureDevOps_Resource_Feed_with_Project
=== PAUSE TestAccAzureDevOps_Resource_Feed_with_Project
=== RUN   TestAccAzureDevOps_Resource_Feed_Soft_Delete
--- PASS: TestAccAzureDevOps_Resource_Feed_Soft_Delete (22.54s)
=== CONT  TestAccAzureDevOps_Resource_FeedPermission
=== CONT  TestAccAzureDevOps_Resource_Feed_with_Project
=== CONT  TestAccAzureDevOps_Resource_Feed
--- PASS: TestAccAzureDevOps_Resource_Feed (4.28s)
--- PASS: TestAccAzureDevOps_Resource_Feed_with_Project (34.61s)
--- PASS: TestAccAzureDevOps_Resource_FeedPermission (49.62s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        74.617s

=== RUN   TestAccAzureDevOps_DataSource_Feed_By_Name
=== PAUSE TestAccAzureDevOps_DataSource_Feed_By_Name
=== RUN   TestAccAzureDevOps_DataSource_Feed_By_Feed_Id
=== PAUSE TestAccAzureDevOps_DataSource_Feed_By_Feed_Id
=== CONT  TestAccAzureDevOps_DataSource_Feed_By_Name
=== CONT  TestAccAzureDevOps_DataSource_Feed_By_Feed_Id
--- PASS: TestAccAzureDevOps_DataSource_Feed_By_Name (15.73s)
--- PASS: TestAccAzureDevOps_DataSource_Feed_By_Feed_Id (16.79s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        23.189s

xuzhang3 commented 4 months ago

@SetsudanHana LGTM

microsoft / terraform-provider-azuredevops