`azuredevops_check_exclusive_lock` with `target_resource_type = "repository"` not working as expected

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and Azure DevOps Provider) Version

Terraform version 18.3 Azure DevOps Provider version 1.0.1

Affected Resource(s)

azuredevops_check_exclusive_lock

Terraform Configuration Files

data "azuredevops_project" "test" {
  name = "MY_TEST_PROJECT"
}

data "azuredevops_git_repository" "test_repo" {
  project_id = data.azuredevops_project.test.id
  name       = "my.test.repo"
}

resource "azuredevops_check_exclusive_lock" "azdo_repo_lock" {
  project_id           = data.azuredevops_project.test.id
  target_resource_id   = data.azuredevops_git_repository.test_repo.id
  target_resource_type = "repository"

  timeout = 30
}

Expected Behavior

An exclusive lock created on the repo

Actual Behavior

╷
│ Error:  failed creating check, project ID: 8d49xxxx-xxxx-xxxx-xxxx-xxxx6745xxxx. Error: Invalid resource id. 5310xxxx-xxxx-xxxx-xxxx-xxxxd0b8xxxx
│ 
│   with azuredevops_check_exclusive_lock.azdo_repo_lock,
│   on main.tf line 1, in resource "azuredevops_check_exclusive_lock" "azdo_repo_lock":
│    1: resource "azuredevops_check_exclusive_lock" "azdo_repo_lock" {
│ 
╵
FAIL

Steps to Reproduce

terraform apply

Workaround / RCA

I captured the network communication when creating this lock on the UI. The payload has "id" as "{projectID}.{repoID}" instead of just "{repoID}", i.e.

"resource": {
  "id": "8d49xxxx-xxxx-xxxx-xxxx-xxxx6745xxxx.5310xxxx-xxxx-xxxx-xxxx-xxxxd0b8xxxx",
  "name": "my.test.repo"
  "type" : "repository"
}

So I have this workaround in my Terraform configuration, and it is working for now:

resource "azuredevops_check_exclusive_lock" "azdo_repo_lock" {
  project_id           = data.azuredevops_project.test.id
  target_resource_id   = "${data.azuredevops_project.test.id}.${data.azuredevops_git_repository.test_repo.id}"
  target_resource_type = "repository"

  timeout = 30
}

But I wish I could just use the expected ${data.azuredevops_git_repository.test_repo.id} or have the documentation letting me know that I have to prefix the project ID here.

Thanks!

References

azuredevops/check_exclusive_lock

microsoft / terraform-provider-azuredevops