microsoft / terraform-provider-azuredevops

Terraform Azure DevOps provider
https://www.terraform.io/docs/providers/azuredevops/
MIT License
380 stars 271 forks source link

Implemented a new resource `ResourceServiceEndpointProjectPermissions` #1031 #1051

Open mouismail opened 4 months ago

mouismail commented 4 months ago

New Resource Implementation:

Testing:

Documentation:


All Submissions:

What about the current behavior has changed?

Issue Number: #1031

Does this introduce a change to go.mod, go.sum or vendor/?

Does this introduce a breaking change?

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

mateustanaka commented 4 months ago

@mouismail You implemented a new resource, why have you updated the existing documentation for azuredevops_serviceendpoint_permissions?

I guess you should create a new documentation page for azuredevops_serviceendpoint_project_permissions because each of the resources has its own responsibilities.

xuzhang3 commented 4 months ago

you need to add the new resource to provider.go otherwise the provider cannot resolve this resource in ADO provider

xuzhang3 commented 4 months ago

Some criteria for new resources:

  1. Add new resource ( azuredevops_xxx.go) and test code azuredevops_wiki_test.go
  2. Add the new resource to provider.go and provider_test.go
  3. Add new document for the new resource and add the index to azuredevops.erb
  4. (Optional) update the vendor if necessary Examples: https://github.com/microsoft/terraform-provider-azuredevops/pull/806
mouismail commented 4 months ago

Some criteria for new resources:

  1. Add new resource ( azuredevops_xxx.go) and test code azuredevops_wiki_test.go
  2. Add the new resource to provider.go and provider_test.go
  3. Add new document for the new resource and add the index to azuredevops.erb
  4. (Optional) update the vendor if necessary Examples: New resource - azuredevops_check_required_template #806

Working on the change together with @mateustanaka request to create a new documentation page for azuredevops_serviceendpoint_project_permissions

mateustanaka commented 3 months ago

Hi @mouismail any update about this item?

mouismail commented 3 months ago

Hi @mateustanaka on it already.

Sharmanand commented 2 months ago

is there timeline this resource will be avaialble to use?