microsoft / terraform-provider-azuredevops

Terraform Azure DevOps provider
https://www.terraform.io/docs/providers/azuredevops/
MIT License
387 stars 278 forks source link

`azuredevops_build_definition`,`azuredevops_build_folder`,`azuredevops_pipeline_authorization`,`azuredevops_resource_authorization` - Optimize CRUD and fix unit tests #1094

Closed xuzhang3 closed 4 months ago

xuzhang3 commented 4 months ago

All Submissions:

What about the current behavior has changed?

Issue Number:

=== RUN   TestAccBuildFolder_basic
=== PAUSE TestAccBuildFolder_basic
=== RUN   TestAccBuildFolder_update
=== PAUSE TestAccBuildFolder_update
=== RUN   TestAccBuildFolder_requiresImportErrorStep
=== PAUSE TestAccBuildFolder_requiresImportErrorStep
=== CONT  TestAccBuildFolder_basic
=== CONT  TestAccBuildFolder_requiresImportErrorStep
=== CONT  TestAccBuildFolder_update
--- PASS: TestAccBuildFolder_basic (54.54s)
--- PASS: TestAccBuildFolder_requiresImportErrorStep (63.59s)
--- PASS: TestAccBuildFolder_update (92.39s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        99.177s

=== RUN   TestAccBuildDefinition_DataSource
=== PAUSE TestAccBuildDefinition_DataSource
=== RUN   TestAccBuildDefinition_with_path_DataSource
=== PAUSE TestAccBuildDefinition_with_path_DataSource
=== RUN   TestAccBuildDefinition_Basic
=== PAUSE TestAccBuildDefinition_Basic
=== RUN   TestAccBuildDefinition_PathUpdate
=== PAUSE TestAccBuildDefinition_PathUpdate
=== RUN   TestAccBuildDefinition_WithVariables
=== PAUSE TestAccBuildDefinition_WithVariables
=== RUN   TestAccBuildDefinition_Schedules
=== PAUSE TestAccBuildDefinition_Schedules
=== CONT  TestAccBuildDefinition_DataSource
=== CONT  TestAccBuildDefinition_WithVariables
=== CONT  TestAccBuildDefinition_Basic
=== CONT  TestAccBuildDefinition_with_path_DataSource
=== CONT  TestAccBuildDefinition_PathUpdate
=== CONT  TestAccBuildDefinition_Schedules
--- PASS: TestAccBuildDefinition_Schedules (63.61s)
--- PASS: TestAccBuildDefinition_DataSource (64.36s)
--- PASS: TestAccBuildDefinition_with_path_DataSource (65.16s)
--- PASS: TestAccBuildDefinition_Basic (66.00s)
--- PASS: TestAccBuildDefinition_PathUpdate (83.36s)
--- PASS: TestAccBuildDefinition_WithVariables (101.00s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        102.464s

=== RUN   TestAccPipelineAuthorization_allPipeline_queue
=== PAUSE TestAccPipelineAuthorization_allPipeline_queue
=== RUN   TestAccPipelineAuthorization_pipeline_queue
=== PAUSE TestAccPipelineAuthorization_pipeline_queue
=== RUN   TestAccPipelineAuthorization_multiPipeline_queue
=== PAUSE TestAccPipelineAuthorization_multiPipeline_queue
=== RUN   TestAccPipelineAuthorization_allPipelineWithPipeline_queue
=== PAUSE TestAccPipelineAuthorization_allPipelineWithPipeline_queue
=== RUN   TestAccPipelineAuthorization_allPipeline_environment
=== PAUSE TestAccPipelineAuthorization_allPipeline_environment
=== RUN   TestAccPipelineAuthorization_pipeline_environment
=== PAUSE TestAccPipelineAuthorization_pipeline_environment
=== RUN   TestAccPipelineAuthorization_allPipeline_variableGroup
=== PAUSE TestAccPipelineAuthorization_allPipeline_variableGroup
=== RUN   TestAccPipelineAuthorization_pipeline_variableGroup
=== PAUSE TestAccPipelineAuthorization_pipeline_variableGroup
=== RUN   TestAccPipelineAuthorization_allPipeline_endpoint
=== PAUSE TestAccPipelineAuthorization_allPipeline_endpoint
=== RUN   TestAccPipelineAuthorization_pipeline_endpoint
=== PAUSE TestAccPipelineAuthorization_pipeline_endpoint
=== RUN   TestAccPipelineAuthorization_allPipeline_repository
=== PAUSE TestAccPipelineAuthorization_allPipeline_repository
=== RUN   TestAccPipelineAuthorization_pipeline_repository
=== PAUSE TestAccPipelineAuthorization_pipeline_repository
=== RUN   TestAccPipelineAuthorization_pipeline_cross_project_repository
=== PAUSE TestAccPipelineAuthorization_pipeline_cross_project_repository
=== CONT  TestAccPipelineAuthorization_allPipeline_queue
=== CONT  TestAccPipelineAuthorization_pipeline_variableGroup
=== CONT  TestAccPipelineAuthorization_allPipeline_environment
=== CONT  TestAccPipelineAuthorization_pipeline_cross_project_repository
=== CONT  TestAccPipelineAuthorization_pipeline_repository
=== CONT  TestAccPipelineAuthorization_allPipeline_endpoint
=== CONT  TestAccPipelineAuthorization_multiPipeline_queue
=== CONT  TestAccPipelineAuthorization_allPipelineWithPipeline_queue
=== CONT  TestAccPipelineAuthorization_allPipeline_variableGroup
=== CONT  TestAccPipelineAuthorization_pipeline_queue
=== CONT  TestAccPipelineAuthorization_pipeline_environment
=== CONT  TestAccPipelineAuthorization_allPipeline_repository
=== CONT  TestAccPipelineAuthorization_pipeline_endpoint
--- PASS: TestAccPipelineAuthorization_allPipeline_environment (79.67s)
--- PASS: TestAccPipelineAuthorization_allPipeline_repository (81.28s)
--- PASS: TestAccPipelineAuthorization_pipeline_repository (81.82s)
--- PASS: TestAccPipelineAuthorization_pipeline_environment (87.55s)
--- PASS: TestAccPipelineAuthorization_allPipelineWithPipeline_queue (89.66s)
--- PASS: TestAccPipelineAuthorization_allPipeline_queue (92.95s)
--- PASS: TestAccPipelineAuthorization_multiPipeline_queue (97.31s)
--- PASS: TestAccPipelineAuthorization_pipeline_queue (97.75s)
--- PASS: TestAccPipelineAuthorization_pipeline_cross_project_repository (98.10s)
--- PASS: TestAccPipelineAuthorization_pipeline_variableGroup (100.66s)
--- PASS: TestAccPipelineAuthorization_allPipeline_variableGroup (101.18s)
--- PASS: TestAccPipelineAuthorization_allPipeline_endpoint (105.60s)
--- PASS: TestAccPipelineAuthorization_pipeline_endpoint (108.51s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        109.080s

=== RUN   TestAccResourceAuthorization_CRUD
=== PAUSE TestAccResourceAuthorization_CRUD
=== RUN   TestAccResourceAuthorization_Definition_CRUD
=== PAUSE TestAccResourceAuthorization_Definition_CRUD
=== CONT  TestAccResourceAuthorization_CRUD
=== CONT  TestAccResourceAuthorization_Definition_CRUD
--- PASS: TestAccResourceAuthorization_Definition_CRUD (87.56s)
--- PASS: TestAccResourceAuthorization_CRUD (94.31s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        94.809s

Does this introduce a change to go.mod, go.sum or vendor/?

Does this introduce a breaking change?

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

xuzhang3 commented 4 months ago

Breaking change: The ID of azuredevops_build_folder has been changed to the project ID as the folder name can be renamed which is used as the ID before