microsoft / terraform-provider-azuredevops

Terraform Azure DevOps provider
https://www.terraform.io/docs/providers/azuredevops/
MIT License
387 stars 278 forks source link

Bug fix `azuredevops_team` - Add members should not fail if the member is already present #1130

Closed nilleb closed 2 months ago

nilleb commented 3 months ago

When adding a member to a group, If this member is already part of the group, We should be considering the mode specified on the resource And NOT fail if the user is already member of the group.

All Submissions:

What about the current behavior has changed?

Issue Number: #1129

Does this introduce a change to go.mod, go.sum or vendor/?

Does this introduce a breaking change?

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

nilleb commented 3 months ago

@microsoft-github-policy-service agree

nilleb commented 3 months ago

@nilleb please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

xuzhang3 commented 2 months ago
=== RUN   TestAccTeam_DataSource_Basic
--- PASS: TestAccTeam_DataSource_Basic (88.53s)
=== RUN   TestAccTeam_CreateAndUpdate
--- PASS: TestAccTeam_CreateAndUpdate (108.87s)
=== RUN   TestAccTeam_CreateAndUpdateAdministrators
--- PASS: TestAccTeam_CreateAndUpdateAdministrators (153.27s)
=== RUN   TestAccTeam_CreateAndUpdateMembers
--- PASS: TestAccTeam_CreateAndUpdateMembers (160.57s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        517.293s
xuzhang3 commented 2 months ago

@nilleb LGTM