Fix OIDC validation & AzureAD Auth

davidcorrigan714 commented 3 months ago

All Submissions:

Fixes #990 by removing the input validation and adding documentation about how credentials are sourced. This allows different providers to use different auth providers in most circumstances.

Fixes #994 by using the correct authentication method for AzureAD for OIDC - should've been a Client Assertion and not a Client Secret.

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ x ] My code follows the code style of this project.
[ ] I ran lint checks locally prior to submission.
[x] Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

The Terraform SDK input validation has been removed.

Issue Number:

Does this introduce a change to `go.mod`, `go.sum` or `vendor/`?

[ ] Yes
[x] No

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

davidcorrigan714 commented 3 months ago

Still not used to GH, don't know if there's a way to mark this as a draft like AzDO can. I haven't tested it locally but putting it up for comments while I remember how to get my machine setup to test local plugins again.

favoretti commented 3 months ago

Still not used to GH, don't know if there's a way to mark this as a draft like AzDO can. I haven't tested it locally but putting it up for comments while I remember how to get my machine setup to test local plugins again.

You should see a "Convert to draft" link there, since you're the author.

davidcorrigan714 commented 3 months ago

Just checked every auth method manually so they should be good now.

microsoft / terraform-provider-azuredevops