microsoft / terraform-provider-azuredevops

Terraform Azure DevOps provider
https://www.terraform.io/docs/providers/azuredevops/
MIT License
372 stars 260 forks source link

cant change timeout for existing azuredevops_check_approval #995

Open drdamour opened 3 months ago

drdamour commented 3 months ago

Community Note

Terraform (and Azure DevOps Provider) Version

Terraform v1.7.0 on windows_amd64

Affected Resource(s)

Terraform Configuration Files

resource "azuredevops_check_approval" "require_iac_mergers_approval_for" {
  project_id           = azuredevops_project.ex.id
  target_resource_id   = exid
  target_resource_type = "environment"

  requester_can_approve = true
  approvers = [
    azuredevops_group.example.origin_id,
  ]

  instructions = "Check the 'Plan Summary' task of the 'plan' job to ensure changes are expected and valid.  Approving will apply the respective plan!"

  # this is in minutes, IaC plans go stale fast so we timeout in a day, but we may find even smaller windows is better
  timeout = 60 * 24
}

Debug Output

Panic Output

Expected Behavior

Actual Behavior

value that was set to 30 days 43200 changed to 1440

got an error: Error: Specified argument was out of the range of valid values. │ Parameter name: Version │ │ with azuredevops_check_approval.require_iac_mergers_approval_for["az-abp01"], │ on app-infra-cloud.tf line 26, in resource "azuredevops_check_approval" "require_iac_mergers_approval_for": │ 26: resource "azuredevops_check_approval" "require_iac_mergers_approval_for" {

Steps to Reproduce

  1. terraform apply

Important Factoids

if i delete the check in azdo web ux and reapply it creates fine...it just seems to be the update that fails

References

xuzhang3 commented 3 months ago

@drdamour cannot reproduce this error. From the logs this issue was brought into this provider by #977 . The int type value should be 0 by default, so not sure what the invalid values is.