microsoft / terraform-provider-fabric

Terraform Provider for Microsoft Fabric
https://registry.terraform.io/providers/microsoft/fabric
Mozilla Public License 2.0
26 stars 5 forks source link

fix(workspace): update resource creation to handle state correctly for identity #96

Open DariuszPorowski opened 2 days ago

DariuszPorowski commented 2 days ago

📥 Pull Request

fix #93

❓ What are you trying to address

This pull request includes changes to the Create method in the resourceWorkspace struct to improve state management and ensure that the state is properly updated. The most important changes include initializing the state variable, setting state.Timeouts and state.ID, and updating the get and Set methods to use state instead of plan.

✨ Description of new changes

State management improvements:

github-actions[bot] commented 2 days ago

Changelog Preview

v0.1.0-dev - November 20, 2024

🪲 Fixed

github-actions[bot] commented 2 days ago

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 80% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 65% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 86% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 84% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 78% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 84% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0
Summary 74% (3604 / 4892) 0

Minimum allowed line rate is 40%

codecov-commenter commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.74%. Comparing base (fd36f3e) to head (572aa2e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #96 +/- ## ======================================= Coverage 77.73% 77.74% ======================================= Files 130 130 Lines 12183 12186 +3 ======================================= + Hits 9471 9474 +3 Misses 2708 2708 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: