This pull request includes significant changes to the development container configuration and the removal of certain features and dependencies. The most important changes include updating the dev container image, modifying environment variables, and removing specific features related to acceptance tests and the Power Platform CLI.
Dev Container Configuration Updates:
Updated the dev container image to mcr.microsoft.com/azterraform:latest and added new run arguments and mounts for Docker. (.devcontainer/devcontainer.json, .devcontainer/devcontainer.jsonL1-R42)
Modified environment variables to be set directly in the containerEnv section instead of using an external .env file. (.devcontainer/devcontainer.json, .devcontainer/devcontainer.jsonL1-R42)
Removal of Features and Dependencies:
Removed the acceptance_test_dependencies feature, including its configuration and installation scripts. (.devcontainer/features/acceptance_test_dependencies/devcontainer-feature.json, [1]; install.sh, [2]; main.tf, [3]
Removed the pac feature, which included the Power Platform CLI installation. (.devcontainer/features/pac/devcontainer-feature.json, [1]; install.sh, [2]
Other Changes:
Updated the provider_installation configuration in the .terraformrc file to use ${GOPATH}/bin instead of /go/bin. (.terraformrc, .terraformrcL6-R6)
Simplified the makefile by removing the servedocs target and updating the unittest, acctest, and test targets to set TF_ACC inline. (makefile, makefileL18-R33)
Removed the mkdocs.yml configuration file, which was used for documentation generation. (mkdocs.yml, mkdocs.ymlL1-L5)This pull request includes significant changes to the development container configuration and the removal of several custom features and scripts related to Terraform provider acceptance tests and the Power Platform CLI. The updates aim to simplify the setup and improve the efficiency of the development environment.
Development Container Configuration Updates:
.devcontainer/devcontainer.json: Updated the base image to mcr.microsoft.com/azterraform:latest, added new runArgs and mounts, and updated VS Code customizations and extensions. Removed several features and environment variable settings, and added new container environment variables.
.devcontainer/features/pac: Removed the entire feature, including devcontainer-feature.json and install.sh, which were used for installing the Power Platform CLI. [1][2]
Codebase Simplification:
.devcontainer/features/local_provider_dev/install.sh: Commented out several commands related to setting up the local provider, fixing permissions, and installing mkdocs. Added installation of delve for debugging.
.terraformrc: Updated the provider_installation configuration to use ${GOPATH}/bin instead of /go/bin for the microsoft/power-platform provider.
Miscellaneous Changes:
makefile: Simplified the userdocs and unittest targets, and removed the servedocs target. Updated the unittest, acctest, and test targets to set the TF_ACC environment variable inline.
mkdocs.yml: Removed the MkDocs configuration file.
This pull request includes significant changes to the development container configuration and the removal of certain features and dependencies. The most important changes include updating the dev container image, modifying environment variables, and removing specific features related to acceptance tests and the Power Platform CLI.
Dev Container Configuration Updates:
mcr.microsoft.com/azterraform:latestand added new run arguments and mounts for Docker. (.devcontainer/devcontainer.json, .devcontainer/devcontainer.jsonL1-R42)containerEnvsection instead of using an external.envfile. (.devcontainer/devcontainer.json, .devcontainer/devcontainer.jsonL1-R42)Removal of Features and Dependencies:
acceptance_test_dependenciesfeature, including its configuration and installation scripts. (.devcontainer/features/acceptance_test_dependencies/devcontainer-feature.json, [1];install.sh, [2];main.tf, [3]pacfeature, which included the Power Platform CLI installation. (.devcontainer/features/pac/devcontainer-feature.json, [1];install.sh, [2]Other Changes:
provider_installationconfiguration in the.terraformrcfile to use${GOPATH}/bininstead of/go/bin. (.terraformrc, .terraformrcL6-R6)makefileby removing theservedocstarget and updating theunittest,acctest, andtesttargets to setTF_ACCinline. (makefile, makefileL18-R33)mkdocs.ymlconfiguration file, which was used for documentation generation. (mkdocs.yml, mkdocs.ymlL1-L5)This pull request includes significant changes to the development container configuration and the removal of several custom features and scripts related to Terraform provider acceptance tests and the Power Platform CLI. The updates aim to simplify the setup and improve the efficiency of the development environment.Development Container Configuration Updates:
.devcontainer/devcontainer.json: Updated the base image tomcr.microsoft.com/azterraform:latest, added newrunArgsandmounts, and updated VS Code customizations and extensions. Removed several features and environment variable settings, and added new container environment variables..devcontainer/devcontainer.env: Removed environment variable settings for Terraform CLI configuration and logging.Removal of Custom Features and Scripts:
.devcontainer/features/acceptance_test_dependencies: Removed the entire feature, includingdevcontainer-feature.json,install.sh, andmain.tf, which were used for setting up local Terraform provider acceptance test dependencies. [1] [2] [3].devcontainer/features/pac: Removed the entire feature, includingdevcontainer-feature.jsonandinstall.sh, which were used for installing the Power Platform CLI. [1] [2]Codebase Simplification:
.devcontainer/features/local_provider_dev/install.sh: Commented out several commands related to setting up the local provider, fixing permissions, and installingmkdocs. Added installation ofdelvefor debugging..terraformrc: Updated theprovider_installationconfiguration to use${GOPATH}/bininstead of/go/binfor themicrosoft/power-platformprovider.Miscellaneous Changes:
makefile: Simplified theuserdocsandunittesttargets, and removed theservedocstarget. Updated theunittest,acctest, andtesttargets to set theTF_ACCenvironment variable inline.mkdocs.yml: Removed the MkDocs configuration file.