This pull request includes several changes to the test suite and workflow configuration. The most important changes involve refactoring test constants for better maintainability and modifying the test workflow to focus on specific test cases.
Test Suite Refactoring:
Introduced constants for solution file names and relative paths in internal/services/solution/resource_solution_test.go to avoid hardcoding file paths and names. ([internal/services/solution/resource_solution_test.goR21-R46](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcR21-R46))
Updated various test functions to use the new constants instead of hardcoded strings for solution file names and paths. ([[1]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL66-R76), [[2]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL81-R96), [[3]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL213-R223), [[4]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL257-R257), [[5]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL280-R288), [[6]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL501-R507), [[7]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL528-R527))
Workflow Configuration:
Commented out the paths filter under the pull_request trigger in .github/workflows/run_tests.yml to run tests on all pull requests regardless of file changes. ([.github/workflows/run_tests.ymlL9-R10](diffhunk://#diff-c2e9f7c1bfaf65da79bbd29ed3ce389b2acc8b4099a257914a7292a66e6b9bc9L9-R10))
Modified the test command in the workflow to run only TestAccSolution test cases instead of all tests, optimizing the workflow for acceptance tests. ([.github/workflows/run_tests.ymlL124-R124](diffhunk://#diff-c2e9f7c1bfaf65da79bbd29ed3ce389b2acc8b4099a257914a7292a66e6b9bc9L124-R124))
This pull request includes several changes to the test suite and workflow configuration. The most important changes involve refactoring test constants for better maintainability and modifying the test workflow to focus on specific test cases.
Test Suite Refactoring:
internal/services/solution/resource_solution_test.go
to avoid hardcoding file paths and names. ([internal/services/solution/resource_solution_test.goR21-R46](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcR21-R46)
)[[1]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL66-R76)
,[[2]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL81-R96)
,[[3]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL213-R223)
,[[4]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL257-R257)
,[[5]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL280-R288)
,[[6]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL501-R507)
,[[7]](diffhunk://#diff-4c25ce6852f408d4f4dc25a22f406738688bf30451dca86088f6b37bffc963bcL528-R527)
)Workflow Configuration:
paths
filter under thepull_request
trigger in.github/workflows/run_tests.yml
to run tests on all pull requests regardless of file changes. ([.github/workflows/run_tests.ymlL9-R10](diffhunk://#diff-c2e9f7c1bfaf65da79bbd29ed3ce389b2acc8b4099a257914a7292a66e6b9bc9L9-R10)
)TestAccSolution
test cases instead of all tests, optimizing the workflow for acceptance tests. ([.github/workflows/run_tests.ymlL124-R124](diffhunk://#diff-c2e9f7c1bfaf65da79bbd29ed3ce389b2acc8b4099a257914a7292a66e6b9bc9L124-R124)
)