Closed mawasile closed 1 month ago
Attention: Patch coverage is 82.80347%
with 119 lines
in your changes missing coverage. Please review.
Project coverage is 76.38%. Comparing base (
3ec1e19
) to head (3f5a3cb
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request includes several changes focused on renaming DTO (Data Transfer Object) types to follow a consistent camelCase naming convention and removing an unused constant. The changes span multiple files and functions, ensuring that the new naming convention is applied uniformly across the codebase.
DTO Renaming:
internal/services/admin_management_application/api_admin_management_application.go
: Updated the DTO type names fromAdminManagementApplicationDto
toadminManagementApplicationDto
in various functions. [1] [2]internal/services/admin_management_application/model_admin_management_application.go
: ChangedAdminManagementApplicationDto
toadminManagementApplicationDto
.internal/services/application/api_application.go
: Renamed multiple DTO types, such asEnvironmentIdDto
toenvironmentIdDto
andTenantApplicationDto
totenantApplicationDto
. [1] [2] [3] [4] [5] [6] [7] [8]internal/services/application/models_application.go
: Updated various DTO type names to camelCase, includingTenantApplicationDto
totenantApplicationDto
andEnvironmentApplicationDto
toenvironmentApplicationDto
. [1] [2] [3] [4] [5]internal/services/authorization/api_user.go
: Changed DTO type names fromUserDto
touserDto
in multiple functions. [1] [2] [3] [4] [5] [6] [7] [8]Constant Removal:
internal/services/admin_management_application/api_admin_management_application.go
: Removed the unused constantADMIN_APP_URL
.This pull request includes several changes aimed at improving code consistency and readability by standardizing type names and removing an unnecessary constant. The most important changes include renaming DTO types to follow a consistent lowercase naming convention and removing theADMIN_APP_URL
constant.Type Renaming for Consistency:
internal/services/admin_management_application/api_admin_management_application.go
: RenamedAdminManagementApplicationDto
toadminManagementApplicationDto
and updated related method signatures and variable names accordingly. [1] [2]internal/services/application/api_application.go
: Renamed various DTO types to follow a consistent lowercase naming convention. For example,TenantApplicationDto
totenantApplicationDto
,EnvironmentApplicationDto
toenvironmentApplicationDto
, and updated related method signatures and variable names accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]internal/services/authorization/api_user.go
: RenamedUserDto
touserDto
and updated related method signatures and variable names accordingly. [1] [2] [3] [4] [5] [6] [7] [8]Removal of Unnecessary Constants:
internal/services/admin_management_application/api_admin_management_application.go
: Removed theADMIN_APP_URL
constant and replaced its usage with the actual URL string in theGetAdminApplication
,RegisterAdminApplication
, andUnregisterAdminApplication
methods. [1] [2] [3]