Closed mawasile closed 3 weeks ago
Attention: Patch coverage is 72.91221%
with 253 lines
in your changes missing coverage. Please review.
Project coverage is 73.78%. Comparing base (
a2344f2
) to head (20d4ea4
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request introduces a new resource for managing Power Platform environment group rule sets, along with several supporting changes across the codebase. The most important changes include the addition of the new resource, updates to various files to support this new resource, and improvements to existing code for better functionality and maintainability.
New Resource Addition:
powerplatform_environment_group_rule_set
with various rule configurations inexamples/resources/powerplatform_environment_group_rule_set/resource.tf
.Supporting Changes for New Resource:
internal/services/environment_group_rule_set/api_environment_group_rule_set.go
.internal/services/environment_group_rule_set/constants.go
.internal/provider/provider.go
andinternal/provider/provider_test.go
[1] [2] [3] [4].Code Improvements:
internal/services/connection/api_connection.go
to use helper functions for building URIs, improving code readability and maintainability [1] [2] [3] [4] [5] [6] [7] [8] [9] [10].internal/helpers/uri.go
.Minor Fixes:
internal/api/request.go
.internal/api/client.go
to handle empty response bodies.These changes collectively enhance the functionality and maintainability of the codebase by introducing new features and improving existing code.