Analyzer: DynamicData should be valid

Evangelink commented 6 months ago

Summary

Title: DynamicData should be valid Category: Usage Description: Default severity: Warning

Please refer to MSTEST0003: Test methods should have valid layout.

Non exhaustive list of constraints:

public (except if discover internals)
static
member should match kind declared on the attribute (property or method)
member should exist
member return type should be valid (IEnumerable<object[]> or IEnumerable<(Value)Tuple<...>>)
if member is property it should be gettable
if member is method, it should not have parameters

nohwnd commented 6 months ago

Would be perfect if this could compare the count and type of parameters when IEnumerable is used.

Evangelink commented 6 months ago

Thanks! I definitely missed these cases here but I described them in the global analyzers ticket.

testplatform-bot commented 6 months ago

✅ Successfully linked to Azure Boards work item(s):

Evangelink commented 5 months ago

@engyebrahim As discussed, postponing to milestone 3.4

xcaptain commented 5 months ago

I also have a issue with DynamicData in vscode test explorer. same cause here?

@Evangelink

nohwnd commented 5 months ago

Moved the above issue to a separate one. This is a work item to create the analyzer, not an issue report.