microsoft / testfx

MSTest framework and adapter
MIT License
679 stars 246 forks source link

remove redundant PackageId #3165

Closed SimonCropp closed 1 week ago

Evangelink commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
Evangelink commented 1 week ago

It appears this is not redundant as it's causing the following build error:

##[error].dotnet\sdk\8.0.101\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5129: (NETCORE_ENGINEERING_TELEMETRY=Build) Warning As Error: - At least one .props file was found in 'build/net462/', but 'build/net462/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.props' was not.
- At least one .targets file was found in 'build/net462/', but 'build/net462/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.targets' was not.
- At least one .props file was found in 'build/net6.0/', but 'build/net6.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.props' was not.
- At least one .targets file was found in 'build/net6.0/', but 'build/net6.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.targets' was not.
- At least one .props file was found in 'build/net7.0/', but 'build/net7.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.props' was not.
- At least one .targets file was found in 'build/net7.0/', but 'build/net7.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.targets' was not.
- At least one .props file was found in 'build/net8.0/', but 'build/net8.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.props' was not.
- At least one .targets file was found in 'build/net8.0/', but 'build/net8.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.targets' was not.
- At least one .props file was found in 'build/netcoreapp3.1/', but 'build/netcoreapp3.1/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.props' was not.
- At least one .targets file was found in 'build/netcoreapp3.1/', but 'build/netcoreapp3.1/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.targets' was not.
- At least one .props file was found in 'build/netstandard2.0/', but 'build/netstandard2.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.props' was not.
- At least one .targets file was found in 'build/netstandard2.0/', but 'build/netstandard2.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.targets' was not.
- At least one .props file was found in 'build/uap10.0/', but 'build/uap10.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.props' was not.
- At least one .targets file was found in 'build/uap10.0/', but 'build/uap10.0/Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.targets' was not.
SimonCropp commented 1 week ago

hmm weird. it should default to the csproj name. no worries will abandon