search

microsoft / tfs-cli

Cross-platform CLI for Microsoft Team Foundation Server and Visual Studio Team Services
MIT License
372 stars 132 forks source link

Extension package is malformed/corrupted #339

Closed yahavi closed 3 years ago

yahavi commented 4 years ago

I'm using tfx extension publish to publish my extension to Azure DevOps marketplace. Publishing with tfx-cli 0.6.4 works fine. With 0.7.4 and above I'm getting an unclear error message: error: Extension package is malformed/corrupted: image

I couldn't find any problems in my extension. Without any logs information I can't even know where to start looking. How can I get more information about this error?

I'm using MacOS.

Thanks.

azlam-abdulsalam commented 4 years ago

I am having the same issue, I noticed the package created is able to be published through the UI. Any updates?

jflinchbaugh commented 4 years ago

How big is the vsix file? I've had this problem when my package grew beyond 19MB. tfx-cli saw this same error, but website would still accept the extension. This link led me to reproduce and prove the 19MB limit: https://developercommunity.visualstudio.com/content/problem/668297/size-limit-to-publish-azure-devops-pipelines-custo.html

yahavi commented 4 years ago

@jflinchbaugh yes, I can approve that TFS CLI cannot publish my extension if it above 19MB. However, In the documentation under Check package size, it is mentioned explicitly that:

Check the size of the vsix after it is packaged. If greater than 50 MB then it needs to be optimized.

For me it looks like an issue with TFS CLI or Azure DevOps REST API. Can someone from the TFS CLI team take a look at this issue? Thanks!

mburumaxwell commented 3 years ago

Facing the same issue. Is there a workaround, other than reducing size?

KinsonDigital commented 3 years ago

I am facing the same issue as well. With the documentation clearly stating that we are allowed to be 50MB or less and marketplace web UI accepting the package with no issues, I think this should be fixed. This might be needed by various release pipelines as well.

KinsonDigital commented 3 years ago

How big is the vsix file? I've had this problem when my package grew beyond 19MB. tfx-cli saw this same error, but website would still accept the extension. This link led me to reproduce and prove the 19MB limit: https://developercommunity.visualstudio.com/content/problem/668297/size-limit-to-publish-azure-devops-pipelines-custo.html

I also think this is strange. The ticket says it was fixed with an update and I am pretty sure that I have the latest tfx-cli version, and this github issue is still open.

nexsodev commented 3 years ago

Same here....

arashi01 commented 3 years ago

How big is the vsix file? I've had this problem when my package grew beyond 19MB. tfx-cli saw this same error, but website would still accept the extension. This link led me to reproduce and prove the 19MB limit: https://developercommunity.visualstudio.com/content/problem/668297/size-limit-to-publish-azure-devops-pipelines-custo.html

I just faced this issue trying to publish to marketplace with tfx-cli 0.9.0.

Also took a lot of searching to find this thread. It would be great if at least the error message was more specific and indicated the issue is package size at least.

RobiNino commented 3 years ago

This issue is really limiting our development and release process. Any intention to fix it?

dwilsonactual commented 3 years ago

The problem with uploading large vsix files has been fixed. The problem was server-side so there is no need to update tfx.

wjdavis5 commented 3 years ago

@dwilsonactual Are you sure this has been resolved?

image

Uploads fine in the UI.

dwilsonactual commented 3 years ago

@wjdavis5 how large is your vsix file?

wjdavis5 commented 3 years ago

38MB

wjdavis5 commented 3 years ago

Hello, wanted to check on this as it will be blocking us pretty soon.

dwilsonactual commented 3 years ago

@wjdavis5 sorry for the difficulty, I've created a bug on the team that owns the responsible service. You can increase visibility by providing feedback at https://developercommunity.visualstudio.com/search?space=21

wjdavis5 commented 3 years ago

Can you link the bug you created please?

dwilsonactual commented 3 years ago

@wjdavis5 unfortunately the bug is on an internal project. The best way to get in contact with the responsible team would be by opening an issue at https://developercommunity.visualstudio.com/search?space=21

wnbittle commented 3 years ago

I'm also seeing this issue (0.9.2) 40 MB extension giving "error: Extension package is malformed/corrupted". The UI accepts it without error. I've opened the following issue:

https://developercommunity.visualstudio.com/t/Extension-package-is-malformedcorrupted/1512680?space=21&entry=myfeedback

wnbittle commented 3 years ago

For what it's worth, I eventually got webpack to work so this is no longer a blocker for me. For details look at this thread https://github.com/microsoft/azure-pipelines-task-lib/issues/667

v-shameerms commented 2 months ago

Hi All

If you are having issue with Publishing the extension with large package size, please reach out to VSMarketplace@microsoft.com.

Thanks