Fix --rev-version bug - Githubissues

microsoft / tfs-cli

Cross-platform CLI for Microsoft Team Foundation Server and Visual Studio Team Services

MIT License

372 stars 132 forks source link

Fix --rev-version bug #359

Closed xinyi-joffre closed 4 years ago

xinyi-joffre commented 4 years ago

Addressing the --rev-version bug in #358.

The json-in-place set function returns an Inplace type object, which was causing issues. This adds a toString so that it can be properly written back to the json file.

jpiquot commented 4 years ago

Hi,

I have the same issue with the --rev-version argument.

PS D:\dev\DevOps\DevOpsExt> tfx extension create --output-path './bin' --manifests-globs 'vss-extension.json' --rev-version (node:28916) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency (Use node --trace-warnings ... to show where the warning was created) TFS Cross Platform Command Line Interface v0.8.3 Copyright Microsoft Corporation

error: TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Inplace

VAllens commented 4 years ago

TFS Cross Platform Command Line Interface v0.8.3
Copyright Microsoft Corporation
error: TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Inplace
npm ERR! code ELIFECYCLE