microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
497 stars 52 forks source link

Wrong background color of hovered/selected folds #100

Closed arcticicestudio closed 2 years ago

arcticicestudio commented 2 years ago

When hovering or selecting the main editor fold line (right next to the number gutter) at a specific position, in order to highlight a code region, the background color does not match to the currently active theme, e.g. Nord.

The "Nord" theme in VS with a hovered/selected region that uses a background color that is not part of the theme.

Even through the fold line is not available in VS Code it would be nice to use a theme specific color, e.g. the background color used to highlight selected text in the editor. I've checked the Nord VS Code theme and found the following keys that could be used as an alternative mapping:

Reproduction Steps

  1. Set Nord as active theme.
  2. Hover over or select a region through the main editor fold line (right next to the number gutter).
  3. Validate that the background color of the highlighted region does not match to the currently active theme, e.g. Nord.

Expected Behavior

I expected that regions, highlighted by the main editor fold line, are styled according to the active theme, e.g. Nord.

Environment

Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version: 17.0.0 Preview 3 Theme(s) used: Nord

(Possible) Release Impact

This issue is kind of a low annoyance that does not block a theme release but can be improved in a future version.