microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
497 stars 52 forks source link

Reversed active line and selection background color #101

Closed arcticicestudio closed 2 years ago

arcticicestudio commented 2 years ago

It looks like the background colors for the line of the cursor and selected text in editor are reversed. Nord in VS Code uses a more subtle (transparent) background color for the line of the cursor (#3b4252) while selected text uses a slightly brighter and more opaque color (#434c5ecc). In VS both styles are currently reversed, that means that the cursor line currently uses are more opaque background color while selections are more transparent.

The "Nord" theme in VS with the highlighting of the current cursor line.

The "Nord" theme in VS with highlighting of selected text.

In comparison the "Nord" theme in VS Code with the correct highlighting of the current cursor line.

In comparison the "Nord" theme in VS Code with the correct highlighting of selected text.

I've checked the Nord VS Code theme and found the following keys that are responsible for the described styles:

Reproduction Steps

Editor Cusror Line

  1. Set Nord as active theme.
  2. Place the cursor in any line in the editor.
  3. Validate that the background color of the line is more opaque compared to selected text.

Selected Editor Text

  1. Set Nord as active theme.
  2. Select any text in the editor.
  3. Validate that the background color of the text is more transparent compared to the line in which the cursor is located.

Expected Behavior

I expected that the background colors of selected text in the editor and the active cursor line are reversed.

Environment

Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version: 17.0.0 Preview 3 Theme(s) used: Nord

(Possible) Release Impact

This issue is kind of a medium annoyance because it might be a bit confusing for users of both VS Code and VS, but this is also not a blocker for a theme release and can be improved in a future version.