microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
497 stars 52 forks source link

Wrong background color for editor hover popups #102

Closed arcticicestudio closed 2 years ago

arcticicestudio commented 2 years ago

The popup that appears when hovering over an element in the editor, e.g. a function/method, that renders information like documentations currently uses the same background color like the editor itself and can only be differentiated by the small border. Nord in VS Code uses a different color (#3b4252, nord1) for such components to stand out from the editor background color.

The "Nord" theme in VS with a open editor hover popup.

In comparison the "Nord" theme in VS Code with an open editor hover popup.

I've checked the Nord VS Code theme and found the following keys that are responsible for the editor hover popup:

Reproduction Steps

  1. Set Nord as active theme.
  2. Hover over an syntax element like a function in the editor.
  3. Validate that the background color of the appearing popup is the same like the background color of the editor.

Expected Behavior

I expected that the background color of editor hover popups are the same like the one used by Nord in VS Code in order to stand out from the editor background color.

Environment

Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version: 17.0.0 Preview 3 Theme(s) used: Nord

(Possible) Release Impact

This issue is kind of a medium annoyance because it might be a bit hard to distinguish and read the hover popup and their content, but this is also not a blocker for a theme release and can be improved in a future version.