microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
497 stars 52 forks source link

Inconsistent tab close icon highlighting on hover #104

Closed arcticicestudio closed 2 years ago

arcticicestudio commented 2 years ago

When hovering over the close icon of the active editor tab the background color is white while inactive tabs use another color of the currently active theme (main accent color?). If this is by design please close this issue, I'd recommend to use only one color for both tab states.

The "Nord" theme in VS with highlighting of a close icon of an active tab.

The "Nord" theme in VS with highlighting of a close icon of an inactive tab.

Reproduction Steps

  1. Set Nord as active theme.
  2. Hover over the close icon of the active editor tab and validate that the background color is a whitish.
  3. Afterwards hover over the close icon of a inactive editor tab and validate that the background color is different, e.g. blusih when using Nord as theme.

Expected Behavior

I expected that the background color editor tab close icons are the same in active & inactive state.

Environment

Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version: 17.0.0 Preview 3 Theme(s) used: Nord

(Possible) Release Impact

This issue is kind of a low annoyance that can be improved in a future version and is not a blocker for a theme release.