Wrong button background color

[arcticicestudio]

The background color of some buttons, e.g. "Save" in the action icon bar, when being hovered or pressed is not part of the currently active theme.

A hovered button with "Nord" set as active VS theme.

A pressed and hold button with "Nord" set as active VS theme.

I've checked the Nord VS Code theme and found the following keys that are responsible for button highlighting:

• button.background - the key for the base background color of button components.
• button.hoverBackground - the key for the base background color of button components when being hovered with the mouse.
• button.secondaryBackground - the key for the secondary background color of button components.
• button.secondaryHoverBackground - the key for the secondary background color of button components when being hovered with the mouse.

Reproduction Steps

1. Set Nord as active theme.
2. Hover over an icon button, e.g. "Save" in the action icon bar, or press and hold it.
3. Validate that the background color is not one used by the currently active theme.

Expected Behavior

I expected that the background color of buttons, in both hovered and pressed state, is the same like for the theme in VS Code, e.g. Nord.

Environment

Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version: 17.0.0 Preview 3 Theme(s) used: Nord

(Possible) Release Impact

This issue is kind of a low annoyance that can be improved in a future version and it not a blocker for a theme release.

[ketttY]

Hi @arcticicestudio, thank you for reporting the issue. In VS, these icons buttons are treated as command menu items and they share the color tokens with other menus items (see screenshots). Therefore, we chose to color them with menubar.selectionBackground from VSC when they are hovered to make the menu looks more consistent with VSC. VS tokens used: