search

microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
497 stars 52 forks source link

Inconsistent window control styling #106

Closed arcticicestudio closed 2 years ago

arcticicestudio commented 2 years ago

The control buttons (minimize, maximize and close) of the main IDE window using a different style than the ones of the launcher window. In my opinion the background color should be more subtle to not disturb the focus of the user as these components also do not play an important role during actual IDE usage.

The control buttons of the launcher window with "Nord" as active VS theme.

In comparison the control buttons of the main IDE window with "Nord" as active VS theme.

The problem reported in #105 can also be seen on the window control buttons.

I've checked the Nord VS Code theme and found the following keys that are responsible for semantic occurrence highlighting:

Reproduction Steps

  1. Set Nord as active theme.
  2. Open VS and validate that the background color of the window control buttons are a bright color (nord8).
  3. Open any project and validate that the window control buttons are now using subtle background color (same as window top bar).

Expected Behavior

I expected that the control buttons of the launcher window use the same style like the main IDE window to not disturb the focus of the user as these components also do not play an important role during actual IDe usage.

Environment

Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version: 17.0.0 Preview 3 Theme(s) used: Nord

(Possible) Release Impact

This issue is kind of a low annoyance that can be improved in a future version and it not a blocker for a theme release.

ketttY commented 2 years ago

Thank you for sharing the feedback, @arcticicestudio! The issue should now be fixed, feel free to reopen it if it still reproduces for you!