Closed arcticicestudio closed 2 years ago
@arcticicestudio thank you for sharing this issue! It does look like a minor annoyance that the folded editor regions don't match the theme. We originally thought that this issue would be fixed with the latest merge but it looks like that's not the case. We can look into this issue along with a later iteration of the tool.
Hi @arcticicestudio, thank you again for your feedback. With the latest change, the collapsed area is now using the same color as the region name. Please note that the collapsed text color is only read at VS start up, therefore, in order to see this change, you will need to first open VS with the new theme patched, select your target theme, and then restart VS.
Attached is the comparison.
Before:
After:
Unfolded:
VS Code folded:
Thanks for the quick fix, works like expected. This also revealed that there are some TextMate scopes missing in Nord for VS Code to style regions in order to style them like comments 😄
Folded regions in the editor using a foreground and border color that is not part of the currently active theme. My suggestions is that such elements are highlighted like comments to not take the focus off the code and improve the consistent code appearance.
Folded code regions with "Nord" set as active VS theme.
Reproduction Steps
Expected Behavior
I expected that the code folds are highlighted like comments to not take the focus off the code and improve the consistent code appearance.
Environment
Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version:
17.0.0 Preview 3
Theme(s) used: Nord(Possible) Release Impact
This issue is kind of a low annoyance because it is only visible when using code foldings so this can be improved in a future version and it not a blocker for a theme release.