search

microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
502 stars 53 forks source link

Use foreground color for info bar hyperlink #131

Closed ketttY closed 2 years ago

ketttY commented 2 years ago

Pending design review. VS Code: image VS Hovered: image VS Not Hovered: image

VS Code always shows an underscore for links, but VS only shows when hovered and when it is not hovered, the link looks the same as normal text, wondering if this is ok?

huguesv commented 2 years ago

Looking at the list of VS Code tokens, the only other option I can see is textLink.activeForeground and textLink.foreground, which would differentiate normal/hovered. They might not be guaranteed to match well with the bannerBackground though. Maybe we've tried it before?

ketttY commented 2 years ago

@huguesv Yea, these colors are not guaranteed to work with the banner background. For Winter is Coming, the textlink.foreground is the exact same color as the bannerbackground... image image

huguesv commented 2 years ago

Ah that's no good. Let's proceed with your change then.