Some conversion bugs

[fisheva]

Hi, here are some bugs I met when I used theme-converter-for-vs to update Eva Theme for VS. These following API I mentioned are all properties in "Colors" of Eva Theme generated json file. I will describe each bug in a paragraph.

These bugs have some same Reproduce Steps and Environment. So I write down here first.

Environment (please complete the following information):

• Converter version: After ketttY 97th commit at Jan 8 (I didn't found the version number).
• VS version: [Professional 2022 (64-bit) , 17.0.4]
• Theme used: [Eva Theme]

To Reproduce Steps to reproduce the behavior: 1，Git clone this repository. git clone git@github.com:fisheva/Eva-Theme-for-VS-for-issue-of-theme-converter-for-vs.git 2，After clone repository above, install Eva Theme for VS by 2022.visx file. 3，Open Eva Theme converter project, double-click 2022.sln(2022/VISX Project/2022.sln) file. 4，In Eva Theme converter project, double-click source.extention.vsixmanifest file.

Additional context The Eva Theme for VS in the repository above is a version used for testing. If you want to experience the official version of Eva Theme for VS, please visit here.

[fisheva]

Bug 1:

Describe the bug "dropdown.background" also affects all background colors in the selection box. See the screenshots below for comparion. The selection background and current select option background in the Eva Light (added "dropdown.background": "#f1f4fb") are all the same. Make the selected texts hard to read.

Screenshots Use Visual Studio default Light theme, screenshot.

Use Eva Light, screenshot.

To Reproduce Steps to reproduce the behavior (after the reproduce steps of paragraph 1): 5，Switch the theme to Eva Light. 6，Click "Assets" → "Edit" → drop down selection box.

Expected behavior The selection background and current select option background affects by "list.activeSelectionBackground" instead of "dropdown.background".

Impact Because of this bug, I have removed "dropdown.background" option in the currently release of the official version of the conversion JSON, the area it affects currently displays the default theme colors.

Additional context If after the repair, the selection background and current select option background is not affected by "list.activeSelectionBackground", please tell me which API it is. Thanks!

[fisheva]

Bug 2:

Describe the bug "statusBar.background" affects both normal, building and debugging status bar background color.

Screenshots Use Visual Studio default Dark theme, screenshot. It's building, and the status bar background color changed.

Use Eva Dark, screenshot. It's building, but the status bar background color didn't change.

To Reproduce Steps to reproduce the behavior (after the reproduce steps of paragraph 1): 5，Switch the theme to Eva Dark. 6，Click tool bar "Build" → "Build solution".

Expected behavior "statusBar.background" affects only normal status bar background color. "statusBar.debuggingBackground" affects both building and debugging status bar background color.

Impact Because of this bug, Eva Theme for VS users can't see the color change of status bar background when building or debugging.

Additional context If after the repair, the building and debugging status bar background color are not affected by "statusBar.debuggingBackground", please tell me which API it is. Thanks!

[fisheva]

Bug 3:

Describe the bug The independently window title color is black both in Eva Dark and Eva Light. And I find no API can affect it's color. When the code window is displayed independently, the color of the title bar is hard to read in Eva Dark.

Screenshots Use Visual Studio default Dark theme, screenshot.

Use Eva Dark, screenshot. The independently window title is hard to read.

Use Eva Test, screenshot. The independently window title color is still black. (Eva Test is a theme I used to initially find the scope of the API. All APIs are set, but none of them are set to black.)

To Reproduce Steps to reproduce the behavior (after the reproduce steps of paragraph 1): 5，Switch the theme to Eva Dark. 6，Drag and drop 'AssemblyInfo.cs' file to a independently window.

Expected behavior The independently window title color is controlled by a generate JSON API.

Impact This bug is reported by an Eva Theme user in this issue.

Additional context After the repair, please tell me which API it is. Thanks!

[fisheva]

Bug 4:

Describe the bug The border color of the currently selected input box and the background color of the selected text in the input box are affected by "foreground" API.

Screenshots Use Visual Studio default Dark theme, screenshot.

Use Eva Dark, screenshot.

Use Eva Dark(Set "foreground":"#0000ff"), screenshot. You can see all UI colors affected by "foreground" API.

To Reproduce Steps to reproduce the behavior (after the reproduce steps of paragraph 1): 5，Switch the theme to Eva Dark. 6，Select some text in a input box.

Expected behavior The border color of the currently selected input box and the background color of the selected text in the input box are affected by "list.activeSelectionBackground" instead of "foreground".

Impact This bug does not affect the use, but affects the theme style.

Additional context If after the repair, the border color of the currently selected input box and the background color of the selected text in the input box are not affected by "list.activeSelectionBackground", please tell me which API it is. Thanks!

[ketttY]

Hi @fisheva, thank you for your feedback! We will look into these issues soon and let you know once the fix is merged!

[ketttY]

Hi @fisheva, for bug 2, I checked VS Code's behavior and seems like the status bar is not changing color during building and I think it might make sense for the converted theme to match VS Code's for better parity? Wondering what do you think? !

For bug 1, 3 and 4, the fix is in #141. The vs code API that controls the floating window title text is titleBar.activeForeground when the window has focus and titleBar.inactiveForeground when the window doesn't have focus. For both text selection issues, the corresponding VS Code API is selection.background.

Feel free to check if the fix matches your expectation and let me know if you have any questions! Thank you!

[ketttY]

Closing this bug as #141 is merged. If the fix did not meet your expectations, feel free to reactivate this bug. Thanks again for your feedback!

[fisheva]

Hi, @ketty! Very sorry for reply late, I have a lot of development tasks these days, only have time to deal with Eva Theme things on weekends.

I have a different opinion on the status bar color bug. Although Eva Theme for VS is converted from Eva Theme for VSCode, since the current service platform is Visual Studio, it should conform to the user habits of Visual Studio platform. Since the default Visual Studio theme status bar changes color during building, other themes are best to keep this feedback, just in a different color style. So I think there needs an option to set the staus bar color during building.

I pulled the latest code of theme-converter-for-vs today and want to update Eva Theme for VS. But I find that my Visual Studio license had expired... I usually use VSCode for development, and use Visual Studio just to test Eva Theme for VS. Can I apply for an available license for both 2019 and 2022 ? (Some Eva Theme users still use VS2019). I appreciate for it!

The last question, a user left a bug report under my Eva Theme for VS Marketplace. I don't know how to deal with it and reply. Is this a bug caused by the conversion process?

[ketttY]

Hi @fisheva, thank you for your reply!

• For the status bar, in a long term, we will consider making a list of tunable controls for this kind of scenarios, so that users can have better control over the result. For now, I have made this branch: dev/ketyang/buildingstatusbar for the behavior that you are looking for: statusBar.debuggingBackground/foreground will control both debugging and building status bar colors in VS. Therefore, if you want, feel free to use that branch as an alternative.
• The "VS.Cider.ComboBoxColor" issue that the user mentioned should be fixed by reconverting the theme with the latest converter.
• From what I know, @gracegtaylor is now looking at the license issue, so she might be able to provide more information on that.

[fisheva]

Hi @ketty, very thanks for solving my issues perfectly！