Visual Studio shows bright line below tabs

[Binaryify]

Describe the bug after covert the theme, Visual Studio shows bright line below tabs and I also see that in official themes

Screenshots

How to avoid that

[fgimian]

Just referencing the original issue where I reported this too https://github.com/Binaryify/OneDark-Pro/issues/736

This is clearly not intentional when you look at the OneDark Pro theme in VS Code, but after conversion, a bright white line is visible below tabs which is extremely distracting.

Is this something that may be optimised or improved in the converter?

Huge thanks Fotis

[Binaryify]

@ketttY

[ketttY]

Hi @Binaryify and @fgimian, thank you for reporting this issue! I am wondering did you try converting with the latest theme converter? With the latest version, it should be using the tab.activeBackground for that divider (the original mapping is using tab.activeBorder but it falls back to tab.activeBackground because the active border color is null for One Dark Pro), which should look like this:

Wondering does this meet your expectations? Thank you!

[ketttY]

To make this behavior more stable (not rely on tab.activeBorder being null), I have created #146 to make this divider always use the color for tab.inactiveBackground.

[Binaryify]

Hi @Binaryify and @fgimian, thank you for reporting this issue! I am wondering did you try converting with the latest theme converter? With the latest version, it should be using the tab.activeBackground for that divider (the original mapping is using tab.activeBorder but it falls back to tab.activeBackground because the active border color is null for One Dark Pro), which should look like this: Wondering does this meet your expectations? Thank you!

yes, I had used the latest theme converter, it is shows the bright line below tabs After I use the dev/ketyang/tab branch, the bright line don't show now

but I think the border line should show in the bottom as same as vscode's

[ketttY]

but I think the border line should show in the bottom as same as vscode's

Unfortunately, that is due to the design difference between VS and VSCode. For selected tabs at the top, the border will be 0,2,0,0 (which means only have a 2px wide border at the top) and the border brush is FileTabSelectedBorderBrushKey. So this is not an issue that the theme converter can fix.

[Binaryify]

@ketttY okay