microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
502 stars 53 forks source link

Error List pane resize separator #147

Closed Binaryify closed 2 years ago

Binaryify commented 2 years ago

Describe the bug It is difficult to see where to place the cursor for resizing the Error List pane when a file is open in the most recent update.

Screenshots

Repeat https://github.com/Binaryify/OneDark-Pro/issues/740

It should have a split line In vscode, it look like this

image
ryanbuening commented 2 years ago

Adding some clarification...this would occur on any pane docked there, not just the error list.

ketttY commented 2 years ago

Hi @Binaryify, sorry for the delayed response, got some high-priority tasks that need to be addressed. I have tried reproducing this issue with One Dark Pro, One Dark Pro Darker, One Dark Pro Flat and One Dark Pro Mix, but none of them produced result like the one in the gif. I am wondering can you let me know which version of One Dark Pro you converted for the official extension? Thank you!

Binaryify commented 2 years ago

@ryanbuening

Binaryify commented 2 years ago

@ketttY I used this json file which generate from the vscode's generate from current theme command https://gist.github.com/Binaryify/81fd565c1ac851b9cf55e852c77caa01

Binaryify commented 2 years ago

also my vs's version is 17.2.3

Binaryify commented 2 years ago

and it look like this in my vs

image
ryanbuening commented 2 years ago

I'm on 17.2.5

OneDark-Pro (Binaryify) theme:

image

Default Dark theme:

image

ketttY commented 2 years ago

@Binaryify and @ryanbuening, thank you both for the clarification! I have created #148 to address this issue. Feel free to take a look and see if that meets your expectations! Thank you!

ryanbuening commented 2 years ago

That looks good to me. 👍

Binaryify commented 2 years ago

thank for the fast response, I just re-generate a new vsix and it look great

ryanbuening commented 2 years ago

@ketttY, could a similar thing be done (border) for the Tabs pane when tabs are placed on the left?...

image

ketttY commented 2 years ago

@ryanbuening, after checking, it looks like VS does not have a border token for that area, so for now the theme converter can't add a border there. Apologize for the inconvenience.