microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
484 stars 48 forks source link

Themes are not working in Visual studio 1.7.9.0+ versions #164

Open Petrarca181 opened 5 months ago

Petrarca181 commented 5 months ago

Describe the bug Most of converted themes from Theme pack like Abyss or Dark+ are not working correctly anymore.

Expected behavior Work as on previous verisons?

Environment (please complete the following information):

Impact Can't code anymore, I need my dark+ back :(

Smenus commented 4 months ago

I'm trying to get before and after screenshots, if I can find a VS installation that hasn't been updated

salkriaf34 commented 4 months ago

Adding to @Smenus's comment:

Examples using the Dark+ theme:

In 17.9.1 (click to expand) ![image](https://github.com/microsoft/theme-converter-for-vs/assets/25638571/f3749b80-755b-41ee-8756-049999d18b09)
In 17.8 (click to expand) ![image](https://github.com/microsoft/theme-converter-for-vs/assets/25638571/e119a606-4c94-4d8c-aa6b-b32c6a93dd0a)
Code (click to expand) ```csharp namespace VS_17_9_Themes { // Usings are not coloured. using System; using System.Net.Http; public static class Program { public static void Main(string[] args) { SomeClass someClass = new(); // Regular method calls are not coloured. someClass.RegularMethodOnOtherClass(); RegularMethodOnSameClass(); // Extension method calls are coloured. someClass.ExtensionMethodOnOtherClass(); } public static void RegularMethodOnSameClass() { Console.WriteLine("Hello"); } } public interface ISomeInterface { } public class SomeClassBase { } public class SomeClass // Interface names are not coloured. : SomeClassBase, ISomeInterface { public void RegularMethodOnOtherClass() { Console.WriteLine("Hello"); } } public static class SomeClassExtensions { public static void ExtensionMethodOnOtherClass(this SomeClass someClass) { Console.WriteLine("Hello"); } } } ```
Petrarca181 commented 4 months ago

I glad I'm not alone. Sadly I was allarming about this since thems stoped working in preview branch. Looks like no one cares about this issue. I also doubt someone from devlabs team will see the bug report....

If you didn't see my reddit post this is some sort of solution:

  1. Download and install Carnation extension.
  2. Apply Broken theme
  3. Open Carnation window
  4. Press "Themes" apply any theme from there.
  5. Press "Themes" than "Reset theme to default"
  6. Voila! Your theme is fixed!
Petrarca181 commented 4 months ago

@salkriaf34

Please hide images/long code under spoilers WOW this is spoiler!

Examples

salkriaf34 commented 4 months ago

A fix from the VS team is coming: https://developercommunity.visualstudio.com/t/Identifier-has-too-high-priority-in-sy/10547451

The workaround that worked for me was setting the Identifier background and foreground to Automatic.

Screenshot ![image](https://github.com/microsoft/theme-converter-for-vs/assets/25638571/5cdc0584-89df-4462-a97a-048d3b74dda0)
Petrarca181 commented 4 months ago

A fix from the VS team is coming: https://developercommunity.visualstudio.com/t/Identifier-has-too-high-priority-in-sy/10547451

The workaround that worked for me was setting the Identifier background and foreground to Automatic.

Screenshot

you are my hero!

abel-nagy commented 4 months ago

A fix from the VS team is coming: https://developercommunity.visualstudio.com/t/Identifier-has-too-high-priority-in-sy/10547451

The workaround that worked for me was setting the Identifier background and foreground to Automatic.

Screenshot

This kind of fixed it for me as well. Thank you!

a-milburn commented 2 months ago

A fix from the VS team is coming: https://developercommunity.visualstudio.com/t/Identifier-has-too-high-priority-in-sy/10547451

The workaround that worked for me was setting the Identifier background and foreground to Automatic. Screenshot

Legend