Alpha is not supported - Githubissues

microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.

MIT License

502 stars 53 forks source link

Alpha is not supported #29

Closed BeardedBear closed 3 years ago

BeardedBear commented 3 years ago

Describe the bug Alpha is not supported

Screenshots

To Reproduce Convert any theme from Bearded Theme

Expected behavior See VSCode screenshot

Environment (please complete the following information):

Converter version: v0.0.2
VS version: 17.0.0 Preview 3.1
Theme used: Bearded Theme

Additional context In order to manage all the variations of my themes, I use the transparency, that allows me to define a color, and that it works in all. I've used this : RGB Alpha with HEX](https://code.visualstudio.com/api/references/theme-color#color-formats)

gracegtaylor commented 3 years ago

Thanks for sharing this issue! We will look into how we might be able to support Alpha or improve support for these areas.

We've recently shipped an update to our converter tool that changes how colors are applied and will improve contrast in a lot of areas. If you haven't already, please feel free to give it a try and let us know what you think! cc @nestevez @ketttY

ketttY commented 3 years ago

Hi @BeardedBear, thank you for your patience and support. Currently VS does not support customized alpha channel for editor colors - the border for the highlight will always be fully opaque and the background's opacity will be 0.25 to make sure the text is readable. Therefore this issue can't be fixed without changes on the VS side. I have routed this feedback to the team to see what we can do about this. For now, we have tried mitigating this issue by improving the mappings and attached is a screenshot of the converted Bearded Theme Arc. Wondering what do you think and is this blocking you from uploading the theme? Thank you!

BeardedBear commented 3 years ago

Hi @ketttY !

I created these themes initially because I could not find one that suited me perfectly mainly because of 2 things:

I like to change VSCode colors according to my current state of mind, without having to get used to the variations of syntax interpretations
Often, themes don't pay attention to details, I like themes where each element is consistent with the others (my psychorigid side).

That's why I used transparency, to keep a common base for all variants, and to be serene when I add new ones.

Knowing all this, in the current state of the conversion tool, there are a bit too many details that scratch my eyes for me to accept uploading it.

A solution I could bring to this, would be to generate a function in my builder that takes in parameter the alpha, and generate a color without alpha, but will take me a little time, I'm in rush these last days for my job until the end of next week (that's also why I delay a little to take time to go back up the syntax issues) :)

ketttY commented 3 years ago

@BeardedBear Thank you for sharing your thoughts and I completely understand your concern. I think this will be a general concern for other users as well. Therefore, I have integrated the color computation into the tool. Below are some sample screenshots: Bearded Theme Arc:

Bearded Theme Oceanic Bearded Theme Monokai Metallian Wondering what do you think?