Converted colors does not match

microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.

MIT License

502 stars 53 forks source link

Converted colors does not match #32

Closed BeardedBear closed 3 years ago

BeardedBear commented 3 years ago

Describe the bug Converted colors does not match, there is one less unit in the reds.

Screenshots Frame 1

To Reproduce Convert Bearded Theme Monokai Metallian from Bearded Theme

Expected behavior See VSCode screenshot

Environment (please complete the following information):

Converter version: v0.0.2
VS version: 17.0.0 Preview 3.1
Theme used: Bearded Theme Monokai Metallian

gracegtaylor commented 3 years ago

Thank you for sharing this issue! It seems like the color match is just a little bit off. This may be due to the way Visual Studio renders colors, and we've noticed color differences in the past as well. We can look into this issue further. cc @ketttY

ketttY commented 3 years ago

Hi @BeardedBear, after checking the generated json for Bearded Theme Monokai Metallian, looks like the token values match the color used by VS:

sidebar.background = #191b24 (color used the file explorer background)
editor.background"= #1e212b (color used for the editor background) and the colors used by VSC also match these values

Wondering do you mind taking another look? Thank you!

BeardedBear commented 3 years ago

I just checked, and indeed you are right, the bug seems to come from VSCode! I captured a video where it uses the color picker of Powertoys and a capture of the JSON and the color rendered by VSCode!

https://user-images.githubusercontent.com/7188702/131982048-de937322-4496-4488-bfd6-af9fb3f21651.mp4

Code_2aPyO3kLUx