search

microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
502 stars 53 forks source link

🎈 Things that didnt work out on converting Deepdark Material Theme #50

Closed onur-ozkan closed 2 years ago

onur-ozkan commented 3 years ago

Describe the bug 1- File Explorer colors are not the same 2- Almost everything(namespaces, variables, string values, comments) completely different color except the background 3- Current line highlighting is not the same

Screenshots Visual Studio Code: vscode

Visual Studio 2020 Preview 3.1 vs-preview

gracegtaylor commented 3 years ago

Thank you for sharing these issues! It looks like the editor colors didn't convert properly, and the Solution Explorer contrast is completely wrong. We can look into these issues.

ketttY commented 3 years ago

Hi Onur, thank you for reporting the issues. We have made some improvements around the editor mappings according to the issues that you have reported. (Attached is a screenshot of the side-to-side comparison.) You might still notice some differences but some of them are caused by VSCode and VS interprets the text element differently (for example: "myParameter" in the comment block on line 26 is interpreted as a quoted string in VSCode, whereas in VS, it is interpreted as a parameter name.) Unfortunately, this kind of issues can't be fixed by the tool, but hopefully with the latest change, you will find the editor colors closer to the original design.

I also noticed that in your screenshot, the solution explorer is not readable. However, I was not able to reproduce it locally. I think it might be related to the fallback logic that we have recently integrated into the tool. Wondering do you mind converting with the latest main and see if that issue persists? Thank you!

image

onur-ozkan commented 3 years ago

Hi Onur, thank you for reporting the issues. We have made some improvements around the editor mappings according to the issues that you have reported. (Attached is a screenshot of the side-to-side comparison.) You might still notice some differences but some of them are caused by VSCode and VS interprets the text element differently (for example: "myParameter" in the comment block on line 26 is interpreted as a quoted string in VSCode, whereas in VS, it is interpreted as a parameter name.) Unfortunately, this kind of issues can't be fixed by the tool, but hopefully with the latest change, you will find the editor colors closer to the original design.

I also noticed that in your screenshot, the solution explorer is not readable. However, I was not able to reproduce it locally. I think it might be related to the fallback logic that we have recently integrated into the tool. Wondering do you mind converting with the latest main and see if that issue persists? Thank you!

image

I think they look similar enough. Great work. I will pull and convert the theme again and then I will upload it to the marketplace. Hopefully, this weekend I can do this.

gracegtaylor commented 3 years ago

@ozkanonur Thanks so much for your support. The new screenshot looks good! We would like to feature Deepdark Material in our official launch, if you are ok with it. When you've uploaded the theme, please let us know!

onur-ozkan commented 3 years ago

@gracegtaylor I wanted to upload Deepdark Material Theme to the marketplace. But I just saw the "File Explorer colors are not the same" problem still going on.

Defaul Deepdark Material:

1

Full Black Deepdark Material:

2

Also, red color keywords/codes have a gray background which is not provided by the theme.

gracegtaylor commented 3 years ago

Thanks for sharing the screenshots, Onur! Tagging @ketttY as it looks like we're seeing a similar issue as before.

ketttY commented 3 years ago

Hi @ozkanonur, thank you for letting us know! Wondering if you have uncommented the json generated by vscode? I am only able to reproduce this issue when the json is not uncommented (as the token we use for the solution explorer foreground is foreground and this token is commented when the json is generated)

onur-ozkan commented 3 years ago

Hi @ozkanonur, thank you for letting us know! Wondering if you have uncommented the json generated by vscode? I am only able to reproduce this issue when the json is not uncommented (as the token we use for the solution explorer foreground is foreground and this token is commented when the json is generated)

I didnt generate anything from vscode. I use this json files directly. I guess I shouldn't do this?

onur-ozkan commented 3 years ago

Color issue with the file explorer fixed by using generated json file from vscode. But the problem with red-colored texts still going. It doesn't look so bad, so tell me if I should wait for fix or publish the theme.

Adsız

ketttY commented 3 years ago

@ozkanonur, please feel free to publish it if you are satisfied with the result and wondering could you kindly provide us the marketplace link after that? (We will continue improving the converter and let you know once this issue is fixed!)

gracegtaylor commented 2 years ago

Updating this thread: We've received that Marketplace link over email, thank you!