microsoft / theme-converter-for-vs

CLI tool that allows you to convert your VS Code color theme to a VS 2022 color theme.
MIT License
502 stars 53 forks source link

Mitigate property icon issue #55

Closed ketttY closed 3 years ago

ketttY commented 3 years ago

The white background in Properties Window is because the native UI does not support alpha channel - VSC token used was menubar.selectionBackground, this token fallback to 1affffff in VSC, which is a transparent white. Changed the mapping to menu.selectionBackground, which falls back to 2c313a(light theme) and 00a7f5 (dark theme) to mitigate the issue. One Dark Pro: image

The other icon issue is also mitigated. image It seems to be related to the inversion logic: when the background is 1affffff, it is recognized as a light background and the icon is displayed in "dark mode". The inversion logic should consider the compound color when the background is not opaque. Will file bug in ADO.