Some drop-down components are styled sub-optimal regarding the contrast of the background to the foreground color.
When opening a drop-down component the currently selected list item uses the background color intented by the Nord theme, but the foreground color is not correct. Instead of using a dark color (nord0) a way too bright color is used (maybe nord4), resulting in almost unreadable text.
The selected drop-down list item with a foreground color that is too bright.
The style is also used for focused drop-down components.
In comparison the "Nord" theme in VS Code with the desired style.
Strangely enough there are also components where hovered drop-down list items are not styled at all.
I've checked the Nord VS Code theme and found the following keys to be responsible for drop-down list items:
dropdown.background - color of the background for drop-down components.
list.activeSelectionBackground - background color of active/selected drop-down list items.
list.activeSelectionForeground - foreground color of active/selected drop-down list items.
Reproduction Steps
Set Nord as active theme.
Open any drop-down, e.g. the one to select the target CPU architecture.
Validate that the foreground color of the selected list item uses a bright bavkground and foreground at the same time.
Expected Behavior
I expected that selected drop-down list items use a dark foreground color in order to visually separate from the background.
Environment
Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e
VS version: 17.0.0 Preview 3Theme(s) used: Nord
(Possible) Release Impact
This issue is kind of a medium annoyance, but I think it's fine to release the theme with the current style and improve it in a future version.
Some drop-down components are styled sub-optimal regarding the contrast of the background to the foreground color. When opening a drop-down component the currently selected list item uses the background color intented by the Nord theme, but the foreground color is not correct. Instead of using a dark color (
nord0) a way too bright color is used (maybenord4), resulting in almost unreadable text.The selected drop-down list item with a foreground color that is too bright.
The style is also used for focused drop-down components.
In comparison the "Nord" theme in VS Code with the desired style.
Strangely enough there are also components where hovered drop-down list items are not styled at all.
I've checked the Nord VS Code theme and found the following keys to be responsible for drop-down list items:
dropdown.background- color of the background for drop-down components.list.activeSelectionBackground- background color of active/selected drop-down list items.list.activeSelectionForeground- foreground color of active/selected drop-down list items.Reproduction Steps
Expected Behavior
I expected that selected drop-down list items use a dark foreground color in order to visually separate from the background.
Environment
Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version:
17.0.0 Preview 3Theme(s) used: Nord(Possible) Release Impact
This issue is kind of a medium annoyance, but I think it's fine to release the theme with the current style and improve it in a future version.