Most drop-down components use the correct foreground color like defined by the Nord theme, but some use a color that is not part of Nord (maybe a default fallback color for dark VS themes?). This is not a major issue, but I noticed this while testing the issue described in #97.
The "Nord" theme in VS where drop-down list items using the wrong foreground color.
I've checked the Nord VS Code theme and found the following keys to be responsible for drop-down list item foreground color:
dropdown.foreground - the key for the base foreground color of drop-down list items.
foreground - the key for the base foreground color.
Reproduction Steps
Set Nord as active theme.
Open any drop-down, e.g. the one to select the target CPU architecture, but do not hover over any list item.
2.1 Alternatively, you can simply look at an inactive/unfocused drop-down that already has an item selected.
Validate that the foreground color of the selected list item uses a darker foreground color instead of Nord's default foreground color (nord4).
Expected Behavior
I expected that unfocused/unselected drop-down list items use Nord's default foreground color instead of a darker one that is not part of Nord.
Environment
Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e
VS version: 17.0.0 Preview 3Theme(s) used: Nord
(Possible) Release Impact
This issue is kind of a low annoyance which one hardly notices and can be improved it in a future version.
Most drop-down components use the correct foreground color like defined by the Nord theme, but some use a color that is not part of Nord (maybe a default fallback color for dark VS themes?). This is not a major issue, but I noticed this while testing the issue described in #97.
The "Nord" theme in VS where drop-down list items using the wrong foreground color.
I've checked the Nord VS Code theme and found the following keys to be responsible for drop-down list item foreground color:
dropdown.foreground- the key for the base foreground color of drop-down list items.foreground- the key for the base foreground color.Reproduction Steps
nord4).Expected Behavior
I expected that unfocused/unselected drop-down list items use Nord's default foreground color instead of a darker one that is not part of Nord.
Environment
Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version:
17.0.0 Preview 3Theme(s) used: Nord(Possible) Release Impact
This issue is kind of a low annoyance which one hardly notices and can be improved it in a future version.