ketttY
commented
2 years ago Hi @arcticicestudio, thank you for reporting this issue! I am wondering did you uncomment the generated json before the conversion? The token we used for the menu is menu.background, and it is commented out by default. After uncomment, the menu should look like this
Almost all menus do not use the theme specific style (background, foreground and shadow colors) but styles that are not part of Nord. I am not sure if it is currently even possible in VS to style these components, but I was able to modify them using Snoop. When there are currently no keys that can be defined/mapped to these components, or when they are platform native, please close this issue.
The "Nord" theme in VS where menus are not styled according to the theme at all.
There are also other VS components that use the same style like menus but looking like a drop-down component.
In VS Code menus are always platform agnostic, but I've checked the Nord VS Code theme and found the following keys that could be used as an alternative mapping:
notifications.background- the key for the background color of notifications which often use the same style as menus.Reproduction Steps
Expected Behavior
I expected that menus are styled according to the active theme, e.g. Nord.
Environment
Converter version: commit 34bbde361cb3511f7b6ae99dd2689c1825cca60e VS version:
17.0.0 Preview 3Theme(s) used: Nord(Possible) Release Impact
This issue is kind of a medium annoyance because it affects large components that can includes other nested components, but I think it's fine to release the theme with the current style and improve it in a future version.