search

microsoft / thrifty

Thrift for Android that saves you methods
Apache License 2.0
544 stars 102 forks source link

Link to thrifty retrofit converter #148

Open reisub opened 7 years ago

reisub commented 7 years ago

Hi Thrifty developers,

thanks for the great lib!

I implemented a retrofit converter for thrifty, can you please take a look at this retrofit PR?

I would be glad to adjust the coding style and make a PR to Thrifty if it makes sense for you to have the converter as part of this repository.

Thanks in advance

benjamin-bader commented 7 years ago

This is pretty cool - nice work!

To mirror Jake's response to your PR, I also don't feel that we'd be good maintainers of this particular project - we don't use Thrift over HTTP at all, and almost certainly never will.

Would you be willing to publish this yourself? I'd be really happy to link to it.

reisub commented 7 years ago

Okay, thanks for the feedback.

The converter is now published here (we're just waiting for it to be linked to jcenter): https://github.com/infinum/thrifty-retrofit-converter

Can you link to it?

benjamin-bader commented 7 years ago

That's great! I'll have a link up soon.

reisub commented 5 years ago

Hi @benjamin-bader, just a friendly reminder about this :)