search

microsoft / thrifty

Thrift for Android that saves you methods
Apache License 2.0
544 stars 102 forks source link

Bump Kotlin to 1.6.20 #469

Closed benjamin-bader closed 2 years ago

benjamin-bader commented 2 years ago

Slightly complicated by the fact that kotest-assertions-compile seems to have fallen into disrepair (pot, kettle, I know); most of its actual logic is in com.github.tschuchortdev:kotlin-compile-testing, and it so happens that by requesting a newer version of that dependency, tests work. Fragile, but good enough for the moment.

I'll probably regret that and end up writing our own kotest/kotlin-compile-testing integration, but not today!

codecov-commenter commented 2 years ago

Codecov Report

Merging #469 (47b7933) into master (41342bc) will decrease coverage by 0.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #469      +/-   ##
============================================
- Coverage     58.79%   58.77%   -0.02%     
+ Complexity      866      861       -5     
============================================
  Files            69       69              
  Lines          6436     6436              
  Branches       1002     1001       -1     
============================================
- Hits           3784     3783       -1     
  Misses         2362     2362              
- Partials        290      291       +1
Impacted Files Coverage Δ
...main/kotlin/com/microsoft/thrifty/schema/Linker.kt 89.89% <0.00%> (-0.51%) :arrow_down:
.../com/microsoft/thrifty/kgen/KotlinCodeGenerator.kt 84.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41342bc...47b7933. Read the comment docs.