microsoft / thrifty

Thrift for Android that saves you methods
Apache License 2.0
544 stars 102 forks source link

Move version catalog into TOML file, put plugins there #472

Closed benjamin-bader closed 2 years ago

benjamin-bader commented 2 years ago

With this PR, I awkwardly fulfill my long-held dream of having all versions defined in ONE place and ONLY ONE place god damn it!

Gradle being Gradle, their TOML version catalog is pretty neat but also kind of broken - plugin support is dicey. We butted up against the issue where one remote dependency provides multiple plugins (e.g. Kotlin), causing Gradle to hurt itself in its confusion.

Feature immaturity aside, the value is real - especially being able to get rid of that awkward KOTLIN_VERSION gradle property that sat off by itself.