Codecov Report

Merging #486 (eaf3841) into master (96a7179) will increase coverage by 0.02%. The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #486      +/-   ##
============================================
+ Coverage     59.15%   59.18%   +0.02%     
- Complexity      865      868       +3     
============================================
  Files            69       69              
  Lines          6481     6488       +7     
  Branches       1010     1012       +2     
============================================
+ Hits           3834     3840       +6     
- Misses         2345     2346       +1     
  Partials        302      302

Impacted Files	Coverage Δ
.../com/microsoft/thrifty/compiler/ThriftyCompiler.kt	`0.00% <0.00%> (ø)`
.../com/microsoft/thrifty/kgen/KotlinCodeGenerator.kt	`84.81% <100.00%> (+0.06%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96a7179...eaf3841. Read the comment docs.

benjamin-bader commented 2 years ago

Sorry for the delay; crazy family visit == no time to think about anything! I appreciate the effort. This basically LGTM but I'd like to make the comment an opt-in feature - that is, it should default to false.

shashachu commented 2 years ago

@benjamin-bader How dare you prioritize family over your volunteer OSS work! :) Anyway, I responded to your comment re the default value. I can update the docs if we end up having different behavior for Java vs Kotlin.

benjamin-bader commented 2 years ago

How dare you prioritize family over your volunteer OSS work! :)

It's one weakness that I indulge, I admit.

Thanks for your contributions, as always!

microsoft / thrifty