search

microsoft / times-excel-reader

MIT License
6 stars 3 forks source link

Fix extra row in timeperiod start column B #5

Closed siddharth-krishna closed 2 years ago

siddharth-krishna commented 2 years ago

I think the "Remove empty rows" line wasn't always working, leading to an extra row of start years B:

    D     B     E     M  Year
0   1  2018  2018  2018  2018
1   1  2019  2019  2019  2019
2   1  2020  2020  2020  2020
3  20  2021  2040  2030  2030
4  20  2041  2060  2050  2050
5      2081

I also updated the computation of B to be a bit more pandas-y, which should be faster and more concise.

siddharth-krishna commented 2 years ago

@samwebster a suggestion for github PRs: changing the default merge strategy to "Squash and merge" (and selecting the option to automatically delete PR branches after merge) helps keep the main branch commit history nice and clean.

samwebster commented 2 years ago

Good point. I've disabled merge and rebase, leaving only squash, and turned on branch deletion

siddharth-krishna commented 2 years ago

Thanks!